[PR #672] [MERGED] Refactor to use Rust 1.58+ format string syntax #658

New issue

Closed

opened 2026-02-28 14:33:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:33:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/672
Author: @Cleboost
Created: 7/14/2025
Status: ✅ Merged
Merged: 7/15/2025
Merged by: @jacksongoode

Base: main ← Head: code-style

📝 Commits (9)

a470035 Refactor to use Rust 1.58+ format string syntax
ffecf96 Merge branch 'main' into code-style
04d8a53 Upgrade create-dmg to fix permission
5b34fa8 Fix create-dmg issue?
747d17b Log create-dmg issue
0c6eeaa Test
473fdf6 Revert
af1190a --skip-jenkins
88b88cc Fix

📊 Changes

35 files changed (+120 additions, -124 deletions)

View changed files

📝 .github/workflows/build.yml (+1 -1)
📝 psst-core/build.rs (+4 -4)
📝 psst-core/src/actor.rs (+1 -1)
📝 psst-core/src/audio/decode.rs (+4 -4)
📝 psst-core/src/audio/output/cpal.rs (+5 -5)
📝 psst-core/src/cache.rs (+5 -5)
📝 psst-core/src/cdn.rs (+1 -1)
📝 psst-core/src/connection/mod.rs (+6 -6)
📝 psst-core/src/error.rs (+5 -5)
📝 psst-core/src/item_id.rs (+3 -3)
📝 psst-core/src/oauth.rs (+7 -10)
📝 psst-core/src/player/file.rs (+4 -4)
📝 psst-core/src/player/item.rs (+4 -4)
📝 psst-core/src/player/mod.rs (+3 -3)
📝 psst-core/src/player/worker.rs (+2 -2)
📝 psst-core/src/session/access_token.rs (+1 -2)
📝 psst-core/src/session/audio_key.rs (+4 -4)
📝 psst-core/src/session/mercury.rs (+1 -1)
📝 psst-core/src/session/mod.rs (+5 -5)
📝 psst-gui/build.rs (+1 -1)

...and 15 more files

📄 Description

Replaces instances of format!(...) with positional arguments (e.g., format!("{}", var)) to the new Rust 1.58+ inline variable syntax (e.g., format!("{var}")). This change improves code readability and consistency across the codebase, and leverages modern Rust formatting features. No functional changes are introduced.

This fix Github Action Code style. (Not sure this is usefull)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/672 **Author:** [@Cleboost](https://github.com/Cleboost) **Created:** 7/14/2025 **Status:** ✅ Merged **Merged:** 7/15/2025 **Merged by:** [@jacksongoode](https://github.com/jacksongoode) **Base:** `main` ← **Head:** `code-style` --- ### 📝 Commits (9) - [`a470035`](https://github.com/jpochyla/psst/commit/a47003599f9872699ac6d13bd877bf21048d93d1) Refactor to use Rust 1.58+ format string syntax - [`ffecf96`](https://github.com/jpochyla/psst/commit/ffecf96c2f52f505dc80a45e5873f00ba6e79dc1) Merge branch 'main' into code-style - [`04d8a53`](https://github.com/jpochyla/psst/commit/04d8a53ee3341787d9dcca74f438226580197a17) Upgrade create-dmg to fix permission - [`5b34fa8`](https://github.com/jpochyla/psst/commit/5b34fa8314b9716a720337cb3f01f8794ad3297d) Fix create-dmg issue? - [`747d17b`](https://github.com/jpochyla/psst/commit/747d17bc636d4baa1af0721102aa26b2f7b893a2) Log create-dmg issue - [`0c6eeaa`](https://github.com/jpochyla/psst/commit/0c6eeaa040cc5388904b6718d49cd9c185026ed3) Test - [`473fdf6`](https://github.com/jpochyla/psst/commit/473fdf6fa2ccdb0bad4e81bca028edbce0befc6e) Revert - [`af1190a`](https://github.com/jpochyla/psst/commit/af1190aff3575dee530a18e4f586e9319323129b) `--skip-jenkins` - [`88b88cc`](https://github.com/jpochyla/psst/commit/88b88cc16f90b6a317542acbe4a916d1d528c6ba) Fix ### 📊 Changes **35 files changed** (+120 additions, -124 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yml` (+1 -1) 📝 `psst-core/build.rs` (+4 -4) 📝 `psst-core/src/actor.rs` (+1 -1) 📝 `psst-core/src/audio/decode.rs` (+4 -4) 📝 `psst-core/src/audio/output/cpal.rs` (+5 -5) 📝 `psst-core/src/cache.rs` (+5 -5) 📝 `psst-core/src/cdn.rs` (+1 -1) 📝 `psst-core/src/connection/mod.rs` (+6 -6) 📝 `psst-core/src/error.rs` (+5 -5) 📝 `psst-core/src/item_id.rs` (+3 -3) 📝 `psst-core/src/oauth.rs` (+7 -10) 📝 `psst-core/src/player/file.rs` (+4 -4) 📝 `psst-core/src/player/item.rs` (+4 -4) 📝 `psst-core/src/player/mod.rs` (+3 -3) 📝 `psst-core/src/player/worker.rs` (+2 -2) 📝 `psst-core/src/session/access_token.rs` (+1 -2) 📝 `psst-core/src/session/audio_key.rs` (+4 -4) 📝 `psst-core/src/session/mercury.rs` (+1 -1) 📝 `psst-core/src/session/mod.rs` (+5 -5) 📝 `psst-gui/build.rs` (+1 -1) _...and 15 more files_ </details> ### 📄 Description Replaces instances of format!(...) with positional arguments (e.g., format!("{}", var)) to the new Rust 1.58+ inline variable syntax (e.g., format!("{var}")). This change improves code readability and consistency across the codebase, and leverages modern Rust formatting features. No functional changes are introduced. This fix Github Action Code style. (Not sure this is usefull) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>