mirror of
https://github.com/jpochyla/psst.git
synced 2026-04-27 07:25:52 +03:00
[GH-ISSUE #87] Build fails on a MacBook Pro M1 running macOS Big Sur version 11.5.2 #65
Labels
No labels
api
bug
build
documentation
duplicate
enhancement
good first issue
help wanted
idea
invalid
linux
lowprio
macos
pull-request
upstream
windows
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/psst#65
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ctsrc on GitHub (Aug 17, 2021).
Original GitHub issue: https://github.com/jpochyla/psst/issues/87
I'm trying to build this on a MacBook Pro M1 running macOS Big Sur version 11.5.2, and the build fails.
rustup run nightly cargo versionBuild invocation and output from the point where it fails.
rustup run nightly cargo build --release@ctsrc commented on GitHub (Aug 17, 2021):
This happens both with stable rust, which I tried first, and with nightly which I then used and which I have pasted the results for above.
@finnatsea commented on GitHub (Aug 17, 2021):
Trying to build on the M1 Macbook Air, I have the same error.
Looks like @lonkle merged a PR that fixed an earlier arm miniaudio M1 issue. Maybe he has some insight on this?
#51 is related.
@mrkev commented on GitHub (Aug 17, 2021):
I did what @lonkle did on #51 (install
llvm, installbindgen, add the feature tominiaudioinpsst-core) and built successfully.@NicholasLYang commented on GitHub (Aug 17, 2021):
Yeah miniaudio doesn't have aarch64 bindings, so compilation fails. This PR should fix it. Adding a bindings folder for
macos-aarch64isn't too hard btw. You'll need to do the following:generate-bindings.rs:rustc generate-bindings generate-bindings.rs./generate-bindingsThere should be a
macos-aarch64folder inminiaudio/miniaudio-sys/bindingsnow. If you switchpsst-coreto use your local copy ofminiaudio, it'll build.@elmcrest commented on GitHub (Aug 17, 2021):
Hey @NicholasLYang
I've failed at "2. set up bindgen" - could you elaborate this a little more for non-rustonauts?... I hope that's the right term :)
@trescenzi commented on GitHub (Aug 17, 2021):
@elmcrest I'm not a particularly knowledgeable rustacean but the following slightly more detailed instructions are what I did to get it to run on my M1 pro:
cd miniaudio-rs && git submodule update --recursive --initllvm:brew install llvmbindgenin the miniaudio folder(unsure if this is necessary):cargo install bindgenrustc generate-bindings.rs./generate-bindingspsst-corepoint to your local miniaudio(inpsst-core/Cargo.tomlchange theminiaudioline to the following two):@VirenMohindra commented on GitHub (Aug 17, 2021):
@trescenzi your detailed instructions were really helpful!
Few points to note for new rust users -- if you haven't added cargo to your
$PATH, you'll definitely need to do that (socargo install bindgenwas required for me).Once you add it your relevant profile, re run the commands listed in the README.md here and everything should build successfully, besides a few warnings.
@jpochyla commented on GitHub (Aug 22, 2021):
Could you please open a PR in https://github.com/jpochyla/miniaudio-rs with the fixed bindings? Thanks!
@prusnak commented on GitHub (Aug 27, 2021):
PR to jpochyla's fork: https://github.com/jpochyla/miniaudio-rs/pull/2
Older PR to upstream: https://github.com/ExPixel/miniaudio-rs/pull/65
@jpochyla commented on GitHub (Aug 28, 2021):
Should be fixed as of
634f2d0, can you confirm?@VirenMohindra commented on GitHub (Aug 28, 2021):
Confirmed working on M1 Air
@prusnak commented on GitHub (Aug 28, 2021):
Confirmed that
634f2d0a02works on M1@jpochyla commented on GitHub (Aug 28, 2021):
Thanks!
new_with_namewithnew#420