[PR #648] [MERGED] Fix lyrics call in request builder #641

Closed
opened 2026-02-28 14:33:44 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/648
Author: @jacksongoode
Created: 6/18/2025
Status: Merged
Merged: 6/19/2025
Merged by: @jacksongoode

Base: mainHead: jackson/fix-lyrics-call


📝 Commits (2)

  • 12f7552 Fix lyrics call by setting base uri in the builder, drop auth token
  • 8070bfe Add back, it seems like vocalRemoval is in most API references on GH

📊 Changes

1 file changed (+7 additions, -10 deletions)

View changed files

📝 psst-gui/src/webapi/client.rs (+7 -10)

📄 Description

I believe this should fix the issue #636. I need to test this and also make sure we don't need the extra headers.

I also took this opportunity to change the cache folders to kebab-case.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/648 **Author:** [@jacksongoode](https://github.com/jacksongoode) **Created:** 6/18/2025 **Status:** ✅ Merged **Merged:** 6/19/2025 **Merged by:** [@jacksongoode](https://github.com/jacksongoode) **Base:** `main` ← **Head:** `jackson/fix-lyrics-call` --- ### 📝 Commits (2) - [`12f7552`](https://github.com/jpochyla/psst/commit/12f7552b745c8cd8a14396a8c110eb3ff8596ff6) Fix lyrics call by setting base uri in the builder, drop auth token - [`8070bfe`](https://github.com/jpochyla/psst/commit/8070bfe9e393925a44daa4ad90aac791a0d2c648) Add back, it seems like `vocalRemoval` is in most API references on GH ### 📊 Changes **1 file changed** (+7 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `psst-gui/src/webapi/client.rs` (+7 -10) </details> ### 📄 Description I believe this should fix the issue #636. I need to test this and also make sure we don't need the extra headers. I also took this opportunity to change the cache folders to kebab-case. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 14:33:44 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/psst#641
No description provided.