[PR #597] [MERGED] General cleanup - scrobbling auth fix #612

New issue

Closed

opened 2026-02-28 14:33:38 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:33:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/597
Author: @jacksongoode
Created: 4/17/2025
Status: ✅ Merged
Merged: 4/18/2025
Merged by: @jacksongoode

Base: main ← Head: lastfm-cleanup

📝 Commits (7)

c4ef450 Cleanup some logic :)
c0b3833 More cleanup
9c29e6c Fix builds
6d9292a Try this?
46247f7 Just use rustfm-scrobble
6562d9d Linting
807d9e5 Lint?

📊 Changes

15 files changed (+451 additions, -267 deletions)

View changed files

📝 Cargo.lock (+333 -137)
📝 Cross.toml (+2 -1)
📝 psst-core/Cargo.toml (+1 -1)
📝 psst-core/src/cdn.rs (+1 -12)
📝 psst-core/src/connection/mod.rs (+1 -1)
📝 psst-core/src/item_id.rs (+1 -1)
📝 psst-core/src/lastfm.rs (+5 -5)
📝 psst-core/src/oauth.rs (+2 -2)
📝 psst-core/src/player/mod.rs (+2 -2)
📝 psst-gui/Cargo.toml (+1 -1)
📝 psst-gui/src/controller/playback.rs (+5 -5)
📝 psst-gui/src/ui/credits.rs (+1 -1)
📝 psst-gui/src/ui/mod.rs (+1 -1)
📝 psst-gui/src/ui/preferences.rs (+93 -95)
📝 psst-gui/src/webapi/client.rs (+2 -2)

📄 Description

I clicked merge a little bit too early, so this is a fix for the logic around the input forms as well as corrections to keep the consistency in the way we debug and log messages.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/597 **Author:** [@jacksongoode](https://github.com/jacksongoode) **Created:** 4/17/2025 **Status:** ✅ Merged **Merged:** 4/18/2025 **Merged by:** [@jacksongoode](https://github.com/jacksongoode) **Base:** `main` ← **Head:** `lastfm-cleanup` --- ### 📝 Commits (7) - [`c4ef450`](https://github.com/jpochyla/psst/commit/c4ef450dac6bec22213413e30d3d9d09a30aca3a) Cleanup some logic :) - [`c0b3833`](https://github.com/jpochyla/psst/commit/c0b3833b3e0ff47c234a25effb9408dd19858b93) More cleanup - [`9c29e6c`](https://github.com/jpochyla/psst/commit/9c29e6c0e9796a42f5e8452d38b8a310b3b75714) Fix builds - [`6d9292a`](https://github.com/jpochyla/psst/commit/6d9292a1a25a3d2a23dc56ce05ce3e26b281751c) Try this? - [`46247f7`](https://github.com/jpochyla/psst/commit/46247f7ab162cc3abd4beec4b2c6d7af63c91d1a) Just use rustfm-scrobble - [`6562d9d`](https://github.com/jpochyla/psst/commit/6562d9d770f1133745d85c8cadda4f2a4214b650) Linting - [`807d9e5`](https://github.com/jpochyla/psst/commit/807d9e561e6fe4d9d044a450b3d2717ca042eb3e) Lint? ### 📊 Changes **15 files changed** (+451 additions, -267 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+333 -137) 📝 `Cross.toml` (+2 -1) 📝 `psst-core/Cargo.toml` (+1 -1) 📝 `psst-core/src/cdn.rs` (+1 -12) 📝 `psst-core/src/connection/mod.rs` (+1 -1) 📝 `psst-core/src/item_id.rs` (+1 -1) 📝 `psst-core/src/lastfm.rs` (+5 -5) 📝 `psst-core/src/oauth.rs` (+2 -2) 📝 `psst-core/src/player/mod.rs` (+2 -2) 📝 `psst-gui/Cargo.toml` (+1 -1) 📝 `psst-gui/src/controller/playback.rs` (+5 -5) 📝 `psst-gui/src/ui/credits.rs` (+1 -1) 📝 `psst-gui/src/ui/mod.rs` (+1 -1) 📝 `psst-gui/src/ui/preferences.rs` (+93 -95) 📝 `psst-gui/src/webapi/client.rs` (+2 -2) </details> ### 📄 Description I clicked merge a little bit too early, so this is a fix for the logic around the input forms as well as corrections to keep the consistency in the way we debug and log messages. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>