[PR #585] [MERGED] UI: Enhance volume slider behavior #609

New issue

Closed

opened 2026-02-28 14:33:37 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:33:37 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/585
Author: @divadiahim
Created: 2/8/2025
Status: ✅ Merged
Merged: 2/10/2025
Merged by: @jacksongoode

Base: main ← Head: impr_vol_slider

📝 Commits (1)

f29c482 added percentage container size constraint

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 psst-gui/src/ui/mod.rs (+2 -1)

📄 Description

This small PR aims to fix the inconsistent slider size, which is currently affected by the text size of the percentage indicator. The variation occurs due to text kerning and changes in width when the number reaches 100, which determines the slider knob to snap from under the cursor.

Current implementation
This implementation

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/585 **Author:** [@divadiahim](https://github.com/divadiahim) **Created:** 2/8/2025 **Status:** ✅ Merged **Merged:** 2/10/2025 **Merged by:** [@jacksongoode](https://github.com/jacksongoode) **Base:** `main` ← **Head:** `impr_vol_slider` --- ### 📝 Commits (1) - [`f29c482`](https://github.com/jpochyla/psst/commit/f29c4829c882db0dbd325ffbbc7651204dbe5ad6) added percentage container size constraint ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `psst-gui/src/ui/mod.rs` (+2 -1) </details> ### 📄 Description This small PR aims to fix the inconsistent slider size, which is currently affected by the text size of the percentage indicator. The variation occurs due to text kerning and changes in width when the number reaches 100, which determines the slider knob to snap from under the cursor. - Current implementation ![broken](https://github.com/user-attachments/assets/a1bc5bc2-2258-464c-ab82-aa4598406f9e) - This implementation ![working](https://github.com/user-attachments/assets/8476aa2e-b939-4f04-8a31-46c36714e692) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>