mirror of
https://github.com/jpochyla/psst.git
synced 2026-04-27 07:25:52 +03:00
[PR #581] [MERGED] Fix for missing album metadata when song played from album #606
Labels
No labels
api
bug
build
documentation
duplicate
enhancement
good first issue
help wanted
idea
invalid
linux
lowprio
macos
pull-request
upstream
windows
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/psst#606
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/jpochyla/psst/pull/581
Author: @jacksongoode
Created: 1/29/2025
Status: ✅ Merged
Merged: 1/30/2025
Merged by: @jacksongoode
Base:
main← Head:jackson/dl-art📝 Commits (4)
cf18550Right click for a surprisee9367baFix for album context info892193eFixes250406cFixes📊 Changes
9 files changed (+143 additions, -34 deletions)
View changed files
📝
psst-gui/src/data/album.rs(+12 -0)📝
psst-gui/src/data/playback.rs(+25 -0)📝
psst-gui/src/delegate.rs(+29 -0)📝
psst-gui/src/ui/album.rs(+20 -2)📝
psst-gui/src/ui/mod.rs(+51 -10)📝
psst-gui/src/ui/playable.rs(+1 -17)📝
psst-gui/src/ui/track.rs(+2 -2)📝
psst-gui/src/webapi/local.rs(+2 -2)📝
psst-gui/src/widget/link.rs(+1 -1)📄 Description
This probably resolves a few issues. One that I noticed was that the album metadata was unknown when we looked at the lyrics of a song that was played from the album, but outside of the context of an album if the song is played from a playlist it does have that album title. I think this could also be related to the MPRIS issue though I'm not sure #425 #368.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.