[PR #581] [MERGED] Fix for missing album metadata when song played from album #606

Closed
opened 2026-02-28 14:33:37 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/581
Author: @jacksongoode
Created: 1/29/2025
Status: Merged
Merged: 1/30/2025
Merged by: @jacksongoode

Base: mainHead: jackson/dl-art


📝 Commits (4)

📊 Changes

9 files changed (+143 additions, -34 deletions)

View changed files

📝 psst-gui/src/data/album.rs (+12 -0)
📝 psst-gui/src/data/playback.rs (+25 -0)
📝 psst-gui/src/delegate.rs (+29 -0)
📝 psst-gui/src/ui/album.rs (+20 -2)
📝 psst-gui/src/ui/mod.rs (+51 -10)
📝 psst-gui/src/ui/playable.rs (+1 -17)
📝 psst-gui/src/ui/track.rs (+2 -2)
📝 psst-gui/src/webapi/local.rs (+2 -2)
📝 psst-gui/src/widget/link.rs (+1 -1)

📄 Description

This probably resolves a few issues. One that I noticed was that the album metadata was unknown when we looked at the lyrics of a song that was played from the album, but outside of the context of an album if the song is played from a playlist it does have that album title. I think this could also be related to the MPRIS issue though I'm not sure #425 #368.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/581 **Author:** [@jacksongoode](https://github.com/jacksongoode) **Created:** 1/29/2025 **Status:** ✅ Merged **Merged:** 1/30/2025 **Merged by:** [@jacksongoode](https://github.com/jacksongoode) **Base:** `main` ← **Head:** `jackson/dl-art` --- ### 📝 Commits (4) - [`cf18550`](https://github.com/jpochyla/psst/commit/cf18550926d6cb814c02b9fc21f6ae2d3f1c1de7) Right click for a surprise - [`e9367ba`](https://github.com/jpochyla/psst/commit/e9367bada7207c21b19e785b68e88362845fb449) Fix for album context info - [`892193e`](https://github.com/jpochyla/psst/commit/892193e3523be54124172b4bd2b577069cbc6916) Fixes - [`250406c`](https://github.com/jpochyla/psst/commit/250406ccb95eec670e2bf81d23dba7680ed3ba49) Fixes ### 📊 Changes **9 files changed** (+143 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `psst-gui/src/data/album.rs` (+12 -0) 📝 `psst-gui/src/data/playback.rs` (+25 -0) 📝 `psst-gui/src/delegate.rs` (+29 -0) 📝 `psst-gui/src/ui/album.rs` (+20 -2) 📝 `psst-gui/src/ui/mod.rs` (+51 -10) 📝 `psst-gui/src/ui/playable.rs` (+1 -17) 📝 `psst-gui/src/ui/track.rs` (+2 -2) 📝 `psst-gui/src/webapi/local.rs` (+2 -2) 📝 `psst-gui/src/widget/link.rs` (+1 -1) </details> ### 📄 Description This probably resolves a few issues. One that I noticed was that the album metadata was unknown when we looked at the lyrics of a song that was played from the album, but outside of the context of an album if the song is played from a playlist it does have that album title. I think this could also be related to the MPRIS issue though I'm not sure #425 #368. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 14:33:37 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/psst#606
No description provided.