[PR #574] [MERGED] Highlight track in nav context from link & fix link resolution loop #604

New issue

Closed

opened 2026-02-28 14:33:36 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:33:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/574
Author: @jacksongoode
Created: 12/24/2024
Status: ✅ Merged
Merged: 12/28/2024
Merged by: @jacksongoode

Base: main ← Head: jackson/highlight-track-link

📝 Commits (5)

ce53a77 Highlight track in nav context from link & fix link resolution loop
0020f3d This should be done elsewhere
27c7079 Linting
eb29495 Small edits
2d3e805 Make this cleaner

📊 Changes

8 files changed (+63 additions, -39 deletions)

View changed files

📝 psst-gui/src/controller/nav.rs (+1 -1)
📝 psst-gui/src/data/mod.rs (+17 -3)
📝 psst-gui/src/data/nav.rs (+11 -11)
📝 psst-gui/src/data/playback.rs (+1 -1)
📝 psst-gui/src/ui/album.rs (+1 -1)
📝 psst-gui/src/ui/mod.rs (+1 -1)
📝 psst-gui/src/ui/track.rs (+14 -5)
📝 psst-gui/src/webapi/client.rs (+17 -16)

📄 Description

This was listed as a to-do item and often bothered me when I wanted to quickly open a Spotify link that someone had sent me. This is probably a more critical feature than I realized it to be.

This PR also fixes the issue where in navigating to a URL determined context, pressing back to navigate backwards would end up leading to resolving the URL once more, putting you in a loop you couldn't get out of.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/574 **Author:** [@jacksongoode](https://github.com/jacksongoode) **Created:** 12/24/2024 **Status:** ✅ Merged **Merged:** 12/28/2024 **Merged by:** [@jacksongoode](https://github.com/jacksongoode) **Base:** `main` ← **Head:** `jackson/highlight-track-link` --- ### 📝 Commits (5) - [`ce53a77`](https://github.com/jpochyla/psst/commit/ce53a7747ed42b0ceff75d4b9cf26eefa8d938e0) Highlight track in nav context from link & fix link resolution loop - [`0020f3d`](https://github.com/jpochyla/psst/commit/0020f3d6aef73ea40d2ebff3aad2ce5d1a796870) This should be done elsewhere - [`27c7079`](https://github.com/jpochyla/psst/commit/27c70795b2773372eef4c126fc46956847351dde) Linting - [`eb29495`](https://github.com/jpochyla/psst/commit/eb294956f507211789d0b2f33f0edc1bca9a060f) Small edits - [`2d3e805`](https://github.com/jpochyla/psst/commit/2d3e805c218e9acf4acf8e8ae4e8d75b7b1ea3a5) Make this cleaner ### 📊 Changes **8 files changed** (+63 additions, -39 deletions) <details> <summary>View changed files</summary> 📝 `psst-gui/src/controller/nav.rs` (+1 -1) 📝 `psst-gui/src/data/mod.rs` (+17 -3) 📝 `psst-gui/src/data/nav.rs` (+11 -11) 📝 `psst-gui/src/data/playback.rs` (+1 -1) 📝 `psst-gui/src/ui/album.rs` (+1 -1) 📝 `psst-gui/src/ui/mod.rs` (+1 -1) 📝 `psst-gui/src/ui/track.rs` (+14 -5) 📝 `psst-gui/src/webapi/client.rs` (+17 -16) </details> ### 📄 Description This was listed as a to-do item and often bothered me when I wanted to quickly open a Spotify link that someone had sent me. This is probably a more critical feature than I realized it to be. This PR also fixes the issue where in navigating to a URL determined context, pressing back to navigate backwards would end up leading to resolving the URL once more, putting you in a loop you couldn't get out of. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>