[PR #549] [MERGED] Deduplicate code and fix a few clippy complaints #595

New issue

Closed

opened 2026-02-28 14:33:34 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:33:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/549
Author: @itsjunetime
Created: 10/23/2024
Status: ✅ Merged
Merged: 10/24/2024
Merged by: @jacksongoode

Base: main ← Head: deduplicate_and_clippy

📝 Commits (1)

6ba0b4c Deduplicate code and fix a few clippy complaints

📊 Changes

6 files changed (+82 additions, -177 deletions)

View changed files

📝 psst-gui/src/ui/mod.rs (+2 -7)
📝 psst-gui/src/ui/playlist.rs (+18 -21)
📝 psst-gui/src/ui/preferences.rs (+1 -1)
📝 psst-gui/src/webapi/client.rs (+59 -145)
📝 psst-gui/src/webapi/local.rs (+1 -1)
📝 psst-gui/src/widget/link.rs (+1 -2)

📄 Description

While I was working on #548, I noticed a few areas where code was unnecessarily copied or did extra work/computation that it didn't need to do. Most of that was in the WebApi client struct, but there were a few other instances elsewhere as well. There were also some issues that clippy was complaining about which I took care of.

As far as I can tell, everything still works just as expected after these changes.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/549 **Author:** [@itsjunetime](https://github.com/itsjunetime) **Created:** 10/23/2024 **Status:** ✅ Merged **Merged:** 10/24/2024 **Merged by:** [@jacksongoode](https://github.com/jacksongoode) **Base:** `main` ← **Head:** `deduplicate_and_clippy` --- ### 📝 Commits (1) - [`6ba0b4c`](https://github.com/jpochyla/psst/commit/6ba0b4c47c9f34691c661482336981277080eda0) Deduplicate code and fix a few clippy complaints ### 📊 Changes **6 files changed** (+82 additions, -177 deletions) <details> <summary>View changed files</summary> 📝 `psst-gui/src/ui/mod.rs` (+2 -7) 📝 `psst-gui/src/ui/playlist.rs` (+18 -21) 📝 `psst-gui/src/ui/preferences.rs` (+1 -1) 📝 `psst-gui/src/webapi/client.rs` (+59 -145) 📝 `psst-gui/src/webapi/local.rs` (+1 -1) 📝 `psst-gui/src/widget/link.rs` (+1 -2) </details> ### 📄 Description While I was working on #548, I noticed a few areas where code was unnecessarily copied or did extra work/computation that it didn't need to do. Most of that was in the WebApi client struct, but there were a few other instances elsewhere as well. There were also some issues that clippy was complaining about which I took care of. As far as I can tell, everything still works just as expected after these changes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>