[PR #535] [MERGED] Lyric support #586

New issue

Closed

opened 2026-02-28 14:33:32 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:33:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/535
Author: @SO9010
Created: 9/30/2024
Status: ✅ Merged
Merged: 10/7/2024
Merged by: @jacksongoode

Base: main ← Head: Lyric-support

📝 Commits (10+)

ae80c20 git push
dd1aded Merge branch 'jpochyla:master' into Lyric-support
9ba0277 Working now
d2b54ff Comment & Lint
57006a6 Cache lyrics and add ability to skip to position in song via lyrics
9aac938 Try for solution to play currently playing song
501da8c Linting & fixes to only change lyrics when focused
1bdabc1 Better formatting for lyrics and fix initialization
381f5e9 Final touch ups with caching
1f23f9c Re-add deser

📊 Changes

14 files changed (+233 additions, -39 deletions)

View changed files

📝 psst-gui/build.rs (+1 -1)
📝 psst-gui/src/cmd.rs (+2 -0)
📝 psst-gui/src/controller/nav.rs (+2 -2)
📝 psst-gui/src/controller/playback.rs (+21 -1)
📝 psst-gui/src/data/mod.rs (+3 -1)
📝 psst-gui/src/data/nav.rs (+5 -0)
📝 psst-gui/src/data/track.rs (+9 -0)
📝 psst-gui/src/ui/home.rs (+24 -28)
➕ psst-gui/src/ui/lyrics.rs (+108 -0)
📝 psst-gui/src/ui/mod.rs (+5 -0)
📝 psst-gui/src/ui/playback.rs (+14 -5)
📝 psst-gui/src/webapi/client.rs (+31 -1)
📝 psst-gui/src/webapi/local.rs (+1 -0)
📝 psst-gui/src/widget/icons.rs (+7 -0)

📄 Description

This is my start-to-finish feature request #349; I believe I have done it in a similar way to LebreSpot.

Currently what I have done is implement the API request and a very rough UI for it. Many improvements are needed for the UI, but currently, there is a new button at the bottom left that redirects you to a page called lyrics when you click it.

I want to implement time-synced lyrics, which shouldn't be too hard.

I would say its about 50% complete.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/535 **Author:** [@SO9010](https://github.com/SO9010) **Created:** 9/30/2024 **Status:** ✅ Merged **Merged:** 10/7/2024 **Merged by:** [@jacksongoode](https://github.com/jacksongoode) **Base:** `main` ← **Head:** `Lyric-support` --- ### 📝 Commits (10+) - [`ae80c20`](https://github.com/jpochyla/psst/commit/ae80c207be4e0016c5deb23f0a5a4b768b3c8b3b) git push - [`dd1aded`](https://github.com/jpochyla/psst/commit/dd1aded43193b796d8a2cec5c1e4a4b56b45374b) Merge branch 'jpochyla:master' into Lyric-support - [`9ba0277`](https://github.com/jpochyla/psst/commit/9ba027793601149001aa323e3fe2943c3a09253d) Working now - [`d2b54ff`](https://github.com/jpochyla/psst/commit/d2b54ffe6aa747a4d1b120f0ceddbc4550f2b572) Comment & Lint - [`57006a6`](https://github.com/jpochyla/psst/commit/57006a68511b18a00899fb9af28217623f4f58ae) Cache lyrics and add ability to skip to position in song via lyrics - [`9aac938`](https://github.com/jpochyla/psst/commit/9aac93882e434ab43a0a742ac0a2a92de0bd6efb) Try for solution to play currently playing song - [`501da8c`](https://github.com/jpochyla/psst/commit/501da8c2302e2729234c433e025c2456e3f13ac4) Linting & fixes to only change lyrics when focused - [`1bdabc1`](https://github.com/jpochyla/psst/commit/1bdabc1465f571fbe1c09fa18523a61d79dcc19f) Better formatting for lyrics and fix initialization - [`381f5e9`](https://github.com/jpochyla/psst/commit/381f5e9bf6e97cb5e273ed7a364e4ed32ef989c6) Final touch ups with caching - [`1f23f9c`](https://github.com/jpochyla/psst/commit/1f23f9cd299d6a713d9f5c4317e47cf84d837df7) Re-add deser ### 📊 Changes **14 files changed** (+233 additions, -39 deletions) <details> <summary>View changed files</summary> 📝 `psst-gui/build.rs` (+1 -1) 📝 `psst-gui/src/cmd.rs` (+2 -0) 📝 `psst-gui/src/controller/nav.rs` (+2 -2) 📝 `psst-gui/src/controller/playback.rs` (+21 -1) 📝 `psst-gui/src/data/mod.rs` (+3 -1) 📝 `psst-gui/src/data/nav.rs` (+5 -0) 📝 `psst-gui/src/data/track.rs` (+9 -0) 📝 `psst-gui/src/ui/home.rs` (+24 -28) ➕ `psst-gui/src/ui/lyrics.rs` (+108 -0) 📝 `psst-gui/src/ui/mod.rs` (+5 -0) 📝 `psst-gui/src/ui/playback.rs` (+14 -5) 📝 `psst-gui/src/webapi/client.rs` (+31 -1) 📝 `psst-gui/src/webapi/local.rs` (+1 -0) 📝 `psst-gui/src/widget/icons.rs` (+7 -0) </details> ### 📄 Description This is my start-to-finish feature request #349; I believe I have done it in a similar way to LebreSpot. Currently what I have done is implement the API request and a very rough UI for it. Many improvements are needed for the UI, but currently, there is a new button at the bottom left that redirects you to a page called lyrics when you click it. I want to implement time-synced lyrics, which shouldn't be too hard. I would say its about 50% complete. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>