[PR #517] [MERGED] New authentication flow to resolve #515 #579

New issue

Closed

opened 2026-02-28 14:33:31 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:33:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/517
Author: @jacksongoode
Created: 8/24/2024
Status: ✅ Merged
Merged: 9/3/2024
Merged by: @jacksongoode

Base: master ← Head: jackson/new-auth-method

📝 Commits (6)

20228cc Add new auth method, but URL needs to be in window
a570998 Move to GUI
51f86e2 Linting
6bf4e6e Unused code
aeb0add Bump
d91b16e Small caps typo

📊 Changes

11 files changed (+632 additions, -102 deletions)

View changed files

📝 Cargo.lock (+429 -5)
📝 psst-core/Cargo.toml (+1 -0)
📝 psst-core/src/connection/mod.rs (+14 -14)
📝 psst-core/src/lib.rs (+1 -0)
➕ psst-core/src/oauth.rs (+119 -0)
📝 psst-core/src/session/access_token.rs (+2 -2)
📝 psst-gui/src/data/config.rs (+12 -5)
📝 psst-gui/src/data/mod.rs (+1 -0)
📝 psst-gui/src/ui/mod.rs (+1 -1)
📝 psst-gui/src/ui/preferences.rs (+51 -74)
📝 psst-gui/src/ui/track.rs (+1 -1)

📄 Description

This resolves the issue with a new OAuth method largely referencing the work done in librespot https://github.com/librespot-org/librespot/pull/1309. After this username/pass is completely depreciated. I may not have removed all unused references so I'd be happy for reviews and edits.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/517 **Author:** [@jacksongoode](https://github.com/jacksongoode) **Created:** 8/24/2024 **Status:** ✅ Merged **Merged:** 9/3/2024 **Merged by:** [@jacksongoode](https://github.com/jacksongoode) **Base:** `master` ← **Head:** `jackson/new-auth-method` --- ### 📝 Commits (6) - [`20228cc`](https://github.com/jpochyla/psst/commit/20228cc5120115201da40dd52020e03fa780b411) Add new auth method, but URL needs to be in window - [`a570998`](https://github.com/jpochyla/psst/commit/a570998e41b364e24ffd614efb158eaf8d4eab4c) Move to GUI - [`51f86e2`](https://github.com/jpochyla/psst/commit/51f86e22f69ede23ad27a2680ec4f9da0775a977) Linting - [`6bf4e6e`](https://github.com/jpochyla/psst/commit/6bf4e6e31fdfad1b0eab1b62625a461ea4a507c6) Unused code - [`aeb0add`](https://github.com/jpochyla/psst/commit/aeb0addee4847e2be4f3bf8d35e713914216e834) Bump - [`d91b16e`](https://github.com/jpochyla/psst/commit/d91b16e4240b7373601138956329aee47f2e4f65) Small caps typo ### 📊 Changes **11 files changed** (+632 additions, -102 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+429 -5) 📝 `psst-core/Cargo.toml` (+1 -0) 📝 `psst-core/src/connection/mod.rs` (+14 -14) 📝 `psst-core/src/lib.rs` (+1 -0) ➕ `psst-core/src/oauth.rs` (+119 -0) 📝 `psst-core/src/session/access_token.rs` (+2 -2) 📝 `psst-gui/src/data/config.rs` (+12 -5) 📝 `psst-gui/src/data/mod.rs` (+1 -0) 📝 `psst-gui/src/ui/mod.rs` (+1 -1) 📝 `psst-gui/src/ui/preferences.rs` (+51 -74) 📝 `psst-gui/src/ui/track.rs` (+1 -1) </details> ### 📄 Description This resolves the issue with a new OAuth method largely referencing the work done in librespot https://github.com/librespot-org/librespot/pull/1309. After this username/pass is completely depreciated. I may not have removed all unused references so I'd be happy for reviews and edits. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>