[PR #506] [MERGED] Add .icns for proper macOS icon support #572

New issue

Closed

opened 2026-02-28 14:33:29 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:33:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/506
Author: @jacksongoode
Created: 7/30/2024
Status: ✅ Merged
Merged: 7/30/2024
Merged by: @jacksongoode

Base: master ← Head: jackson/mac-icon-fix

📝 Commits (8)

a7503e2 Fix
97a9ac6 Cleanup script
0d572c2 Larger set of icons?
c6f349f Try with create-dmg
c008d6a Fix
c469125 A little narrower
27650da Smaller icns file
e50fc4d No longer need pngs

📊 Changes

4 files changed (+80 additions, -11 deletions)

View changed files

📝 .github/workflows/build.yml (+20 -4)
📝 psst-gui/Cargo.toml (+1 -7)
➕ psst-gui/assets/logo.icns (+0 -0)
➕ psst-gui/build-icons.sh (+59 -0)

📄 Description

I think we needed the .icns file

Should close https://github.com/jpochyla/psst/issues/465

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/506 **Author:** [@jacksongoode](https://github.com/jacksongoode) **Created:** 7/30/2024 **Status:** ✅ Merged **Merged:** 7/30/2024 **Merged by:** [@jacksongoode](https://github.com/jacksongoode) **Base:** `master` ← **Head:** `jackson/mac-icon-fix` --- ### 📝 Commits (8) - [`a7503e2`](https://github.com/jpochyla/psst/commit/a7503e23ca1aec2cd8d1b46892750aa615d641cf) Fix - [`97a9ac6`](https://github.com/jpochyla/psst/commit/97a9ac6a4f36a5d9ebe3944d81845b263fe0e8dd) Cleanup script - [`0d572c2`](https://github.com/jpochyla/psst/commit/0d572c257ae66e1fa80d19f074ed479597255a11) Larger set of icons? - [`c6f349f`](https://github.com/jpochyla/psst/commit/c6f349f60fa88c70e3506fdda5e77e8052cadfa6) Try with create-dmg - [`c008d6a`](https://github.com/jpochyla/psst/commit/c008d6a322ee84def773df03cb9d1a7dcc8b83ee) Fix - [`c469125`](https://github.com/jpochyla/psst/commit/c469125b8979357c24d4fdcf8f6378f4eb7679aa) A little narrower - [`27650da`](https://github.com/jpochyla/psst/commit/27650dafea4a93cdfeaa24519fa683a5a2d0dc05) Smaller icns file - [`e50fc4d`](https://github.com/jpochyla/psst/commit/e50fc4d97f0ea491d1cd4f5caa148e762121b081) No longer need pngs ### 📊 Changes **4 files changed** (+80 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yml` (+20 -4) 📝 `psst-gui/Cargo.toml` (+1 -7) ➕ `psst-gui/assets/logo.icns` (+0 -0) ➕ `psst-gui/build-icons.sh` (+59 -0) </details> ### 📄 Description I think we needed the .icns file Should close https://github.com/jpochyla/psst/issues/465 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>