[PR #504] [MERGED] Make volume slider one line #571

New issue

Closed

opened 2026-02-28 14:33:29 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:33:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/504
Author: @jacksongoode
Created: 7/26/2024
Status: ✅ Merged
Merged: 7/29/2024
Merged by: @jacksongoode

Base: master ← Head: jackson/volume-one-line

📝 Commits (4)

944197b Make volume slider one line
6755200 Cozy style
f6da9b4 A few touch ups
9db95df Make it simple and lower the height of the settings square

📊 Changes

2 files changed (+13 additions, -14 deletions)

View changed files

📝 psst-gui/src/ui/mod.rs (+11 -13)
📝 psst-gui/src/ui/user.rs (+2 -1)

📄 Description

It never made any sense to me why the volume controls were on two separate lines. It only contributed to the height of that very minimal controls panel. I think this makes a lot more sense and we don't need the volume title given that this is intuitive.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/504 **Author:** [@jacksongoode](https://github.com/jacksongoode) **Created:** 7/26/2024 **Status:** ✅ Merged **Merged:** 7/29/2024 **Merged by:** [@jacksongoode](https://github.com/jacksongoode) **Base:** `master` ← **Head:** `jackson/volume-one-line` --- ### 📝 Commits (4) - [`944197b`](https://github.com/jpochyla/psst/commit/944197babc2e86c67b44cd05c1c44eafa49b58c3) Make volume slider one line - [`6755200`](https://github.com/jpochyla/psst/commit/6755200171be3b074b4d4b12afdc36e926297bf4) Cozy style - [`f6da9b4`](https://github.com/jpochyla/psst/commit/f6da9b44b6a2b0e450635dd59731b45f8ecfc53e) A few touch ups - [`9db95df`](https://github.com/jpochyla/psst/commit/9db95df8fad1d0448b2093d0819408738cca7b8f) Make it simple and lower the height of the settings square ### 📊 Changes **2 files changed** (+13 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `psst-gui/src/ui/mod.rs` (+11 -13) 📝 `psst-gui/src/ui/user.rs` (+2 -1) </details> ### 📄 Description It never made any sense to me why the volume controls were on two separate lines. It only contributed to the height of that very minimal controls panel. I think this makes a lot more sense and we don't need the volume title given that this is intuitive. <img width="400" alt="image" src="https://github.com/user-attachments/assets/0c802ede-04f3-4b5a-8c3e-0cc803f005f8"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>