[PR #495] [MERGED] Cache album art #565

New issue

Closed

opened 2026-02-28 14:33:28 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:33:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/495
Author: @jacksongoode
Created: 7/9/2024
Status: ✅ Merged
Merged: 7/11/2024
Merged by: @Insprill

Base: master ← Head: jackson/cache-album-art

📝 Commits (2)

846c5e1 Cache album art (first pass)
4ca368b Small linting issue

📊 Changes

2 files changed (+40 additions, -0 deletions)

View changed files

📝 psst-gui/src/webapi/cache.rs (+27 -0)
📝 psst-gui/src/webapi/client.rs (+13 -0)

📄 Description

Currently, this stores the album art work by hashed URI.

Ideally, we would be storing and retrieving the album art by the album ID. However, that would mean modifying the function in a way that I think would warrant its own PR. With that extension, we would only need to download album artwork for each album rather than album art for each track, which is happening now.

I think the increase in cache size is negligible here, given that each album cover as a small thumbnail is about 2-6kb and has a large thumbnail about ~40kb.

This will reduce the number of requests, improve responsiveness and CPU likely.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/495 **Author:** [@jacksongoode](https://github.com/jacksongoode) **Created:** 7/9/2024 **Status:** ✅ Merged **Merged:** 7/11/2024 **Merged by:** [@Insprill](https://github.com/Insprill) **Base:** `master` ← **Head:** `jackson/cache-album-art` --- ### 📝 Commits (2) - [`846c5e1`](https://github.com/jpochyla/psst/commit/846c5e11426769a01fce6978c3cf3a9aafa27d16) Cache album art (first pass) - [`4ca368b`](https://github.com/jpochyla/psst/commit/4ca368ba08bfdea2c881bc4c3e4919e761a7d67a) Small linting issue ### 📊 Changes **2 files changed** (+40 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `psst-gui/src/webapi/cache.rs` (+27 -0) 📝 `psst-gui/src/webapi/client.rs` (+13 -0) </details> ### 📄 Description Currently, this stores the album art work by hashed URI. Ideally, we would be storing and retrieving the album art by the album ID. However, that would mean modifying the function in a way that I think would warrant its own PR. With that extension, we would only need to download album artwork for each album rather than album art for each track, which is happening now. I think the increase in cache size is negligible here, given that each album cover as a small thumbnail is about 2-6kb and has a large thumbnail about ~40kb. This will reduce the number of requests, improve responsiveness and CPU likely. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>