[PR #485] [CLOSED] Layout Change: Queue View Widget #557

New issue

Closed

opened 2026-02-28 14:33:26 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:33:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/485
Author: @SO9010
Created: 6/30/2024
Status: ❌ Closed

Base: main ← Head: master

📝 Commits (10+)

2295cef Add ability to add to queue
856a70a add ability to take queued song to other playlists, TODO: make it so it passes the song so it can be displayed in the corner
7f0bab4 Add to queue rework - Now queues are held
ecd8546 Fix if switching contexts e.g: playing a different song from a different album, retains added queue.
9a99249 Change added_items to user_added_items, Lint using clippy.
8f13fdd Linting done with format
bc9791f Var name to user_items
a00272b Remove redundant comment
4f5296a UI change starting
6f27d9b Merge branch 'master' of https://github.com/SO9010/psst

📊 Changes

16 files changed (+397 additions, -47 deletions)

View changed files

📝 psst-core/src/player/mod.rs (+10 -0)
📝 psst-core/src/player/queue.rs (+56 -1)
📝 psst-gui/build.rs (+1 -1)
📝 psst-gui/src/cmd.rs (+5 -0)
📝 psst-gui/src/controller/playback.rs (+68 -2)
📝 psst-gui/src/data/config.rs (+2 -0)
📝 psst-gui/src/data/mod.rs (+17 -5)
📝 psst-gui/src/data/playback.rs (+11 -0)
📝 psst-gui/src/ui/home.rs (+24 -28)
📝 psst-gui/src/ui/mod.rs (+10 -2)
📝 psst-gui/src/ui/playback.rs (+5 -5)
📝 psst-gui/src/ui/preferences.rs (+6 -0)
➕ psst-gui/src/ui/queued.rs (+149 -0)
📝 psst-gui/src/ui/track.rs (+1 -1)
📝 psst-gui/src/widget/icons.rs (+6 -0)
📝 psst-gui/src/widget/utils.rs (+26 -2)

📄 Description

This is addressing #476 on creating a new layout and this is a draft PR so that @jacksongoode is able to collaborate with me.

Features:

Fix sizing on the left and right panel
A sidebar on the right which hides with depending on the window size
A new divider for the left and right sides as that was brought in by the split view which I changed to be a flex row so then the left and right bars don't take up too much space
Queue handling functions
- Clear queue
- Remove from queue

Questions:

Is it worth aligning some of the dividers for aesthetic purposes?
Should we have a function which skips to the place in the user queue where the user clicks, I would advocate for this?
What should we do after the song has been played from the queue, should it be removed from the view, or should we implement some sort of auto scroll?
I think we should have an option to disable this queue somewhere, maybe in settings or maybe in the top right of the title bar like here:

Current look of this PR:

https://github.com/jpochyla/psst/assets/77629938/e1d097dc-89ab-4cdb-8585-583db7b69625

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/485 **Author:** [@SO9010](https://github.com/SO9010) **Created:** 6/30/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `master` --- ### 📝 Commits (10+) - [`2295cef`](https://github.com/jpochyla/psst/commit/2295cef770190c38eb1840890924346bfc878f3a) Add ability to add to queue - [`856a70a`](https://github.com/jpochyla/psst/commit/856a70aa47322bee9ee2017926ca5bd179a2824f) add ability to take queued song to other playlists, TODO: make it so it passes the song so it can be displayed in the corner - [`7f0bab4`](https://github.com/jpochyla/psst/commit/7f0bab48f0a082aa3f1407b856cbc76011beba85) Add to queue rework - Now queues are held - [`ecd8546`](https://github.com/jpochyla/psst/commit/ecd8546bf39d0768963109c9a6868744051353b9) Fix if switching contexts e.g: playing a different song from a different album, retains added queue. - [`9a99249`](https://github.com/jpochyla/psst/commit/9a9924963cc65e733e65a45c832050eeb326b84c) Change added_items to user_added_items, Lint using clippy. - [`8f13fdd`](https://github.com/jpochyla/psst/commit/8f13fddd1aa7ed829ae662a283cc669c67396cca) Linting done with format - [`bc9791f`](https://github.com/jpochyla/psst/commit/bc9791fcb40b3fa19561bbc7f5c07b4716b46d17) Var name to user_items - [`a00272b`](https://github.com/jpochyla/psst/commit/a00272b31e7ae20ea55ae09b178b06b3bfd75239) Remove redundant comment - [`4f5296a`](https://github.com/jpochyla/psst/commit/4f5296a4f5d8e4125d6e9a049ed8fa33242715d4) UI change starting - [`6f27d9b`](https://github.com/jpochyla/psst/commit/6f27d9b2b56890ca76157600952cfc6ff4875bdc) Merge branch 'master' of https://github.com/SO9010/psst ### 📊 Changes **16 files changed** (+397 additions, -47 deletions) <details> <summary>View changed files</summary> 📝 `psst-core/src/player/mod.rs` (+10 -0) 📝 `psst-core/src/player/queue.rs` (+56 -1) 📝 `psst-gui/build.rs` (+1 -1) 📝 `psst-gui/src/cmd.rs` (+5 -0) 📝 `psst-gui/src/controller/playback.rs` (+68 -2) 📝 `psst-gui/src/data/config.rs` (+2 -0) 📝 `psst-gui/src/data/mod.rs` (+17 -5) 📝 `psst-gui/src/data/playback.rs` (+11 -0) 📝 `psst-gui/src/ui/home.rs` (+24 -28) 📝 `psst-gui/src/ui/mod.rs` (+10 -2) 📝 `psst-gui/src/ui/playback.rs` (+5 -5) 📝 `psst-gui/src/ui/preferences.rs` (+6 -0) ➕ `psst-gui/src/ui/queued.rs` (+149 -0) 📝 `psst-gui/src/ui/track.rs` (+1 -1) 📝 `psst-gui/src/widget/icons.rs` (+6 -0) 📝 `psst-gui/src/widget/utils.rs` (+26 -2) </details> ### 📄 Description This is addressing #476 on creating a new layout and this is a draft PR so that @jacksongoode is able to collaborate with me. ### Features: - [x] Fix sizing on the left and right panel - [x] A sidebar on the right which hides with depending on the window size - [x] A new divider for the left and right sides as that was brought in by the split view which I changed to be a flex row so then the left and right bars don't take up too much space - [x] Queue handling functions - Clear queue - Remove from queue ### Questions: - Is it worth aligning some of the dividers for aesthetic purposes? - Should we have a function which skips to the place in the user queue where the user clicks, I would advocate for this? - What should we do after the song has been played from the queue, should it be removed from the view, or should we implement some sort of auto scroll? - I think we should have an option to disable this queue somewhere, maybe in settings or maybe in the top right of the title bar like here: ![image](https://github.com/jpochyla/psst/assets/77629938/5e80f0d4-3b64-479e-b4cf-f2f04214c83f) --- ### Current look of this PR: https://github.com/jpochyla/psst/assets/77629938/e1d097dc-89ab-4cdb-8585-583db7b69625 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>