[PR #484] [MERGED] Fix macOS universal build & support macOS >= 11 #556

New issue

Closed

opened 2026-02-28 14:33:26 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:33:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/484
Author: @jacksongoode
Created: 6/26/2024
Status: ✅ Merged
Merged: 7/1/2024
Merged by: @jacksongoode

Base: master ← Head: jackson/fix-mac-uni-build

📝 Commits (10+)

9c8fefb Fix macOS universal build
48f88ba Return cargo release & bump actions
65ae365 Linting?
aa23762 Fix for macOS
58b57bd Fix
939eba5 Fix
054f5f0 Fix for rel dir
28ee7f5 Fix?
84060c6 Revert
35a15d2 Small fix

📊 Changes

3 files changed (+38 additions, -33 deletions)

View changed files

📝 .github/workflows/build.yml (+35 -30)
📝 psst-gui/src/data/album.rs (+1 -1)
📝 psst-gui/src/webapi/client.rs (+2 -2)

📄 Description

This fixes an issue with our universal builds, it also:

adds the MACOSX_DEPLOYMENT_TARGET so we can support older versions than what the macOS runner is set to
Lints a few depreciated usize imports
Bumps the version of the actions to use Node 20 so we don't get depreciation warnings

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/484 **Author:** [@jacksongoode](https://github.com/jacksongoode) **Created:** 6/26/2024 **Status:** ✅ Merged **Merged:** 7/1/2024 **Merged by:** [@jacksongoode](https://github.com/jacksongoode) **Base:** `master` ← **Head:** `jackson/fix-mac-uni-build` --- ### 📝 Commits (10+) - [`9c8fefb`](https://github.com/jpochyla/psst/commit/9c8fefb1ae2793e12c8dde7759d02d1319f02f9b) Fix macOS universal build - [`48f88ba`](https://github.com/jpochyla/psst/commit/48f88ba444f9b8b09fb6faca85cfa4814dcc3e58) Return cargo release & bump actions - [`65ae365`](https://github.com/jpochyla/psst/commit/65ae365808d7c06fdd815c3463b9456d665e6cff) Linting? - [`aa23762`](https://github.com/jpochyla/psst/commit/aa237625de5cd05e3db6acf3328d1e3d38de1f7e) Fix for macOS - [`58b57bd`](https://github.com/jpochyla/psst/commit/58b57bdc3fb823dd6a71c6eed21d369b0622bf36) Fix - [`939eba5`](https://github.com/jpochyla/psst/commit/939eba57586caa5764a172ce0614273ec9713d31) Fix - [`054f5f0`](https://github.com/jpochyla/psst/commit/054f5f0fe195975ff9050b2ddd2958191820f35e) Fix for rel dir - [`28ee7f5`](https://github.com/jpochyla/psst/commit/28ee7f50ea1d00308b09308741534ff6c3467b06) Fix? - [`84060c6`](https://github.com/jpochyla/psst/commit/84060c6844d7830ae691092d9925bf0022e766a4) Revert - [`35a15d2`](https://github.com/jpochyla/psst/commit/35a15d27211381b6252a51812cd8fc9ca32b5567) Small fix ### 📊 Changes **3 files changed** (+38 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yml` (+35 -30) 📝 `psst-gui/src/data/album.rs` (+1 -1) 📝 `psst-gui/src/webapi/client.rs` (+2 -2) </details> ### 📄 Description This fixes an issue with our universal builds, it also: - adds the `MACOSX_DEPLOYMENT_TARGET` so we can support older versions than what the macOS runner is set to - Lints a few depreciated `usize` imports - Bumps the version of the actions to use Node 20 so we don't get depreciation warnings --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>