[PR #478] [CLOSED] Add Close Button to Notifications and Improve Cosmetic Appearance #551

New issue

Closed

opened 2026-02-28 14:33:25 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:33:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/478
Author: @SO9010
Created: 6/12/2024
Status: ❌ Closed

Base: master ← Head: feature/rework-ui

📝 Commits (2)

d7e89ed Add close button to alerts
9d9acb1 Merge branch 'jpochyla:master' into feature/rework-ui

📊 Changes

2 files changed (+17 additions, -2 deletions)

View changed files

📝 psst-gui/src/ui/mod.rs (+10 -2)
📝 psst-gui/src/widget/icons.rs (+7 -0)

📄 Description

This merge request partially addresses issue #255, which I believe stems from an upstream issue. After exploring several solutions, including making the notification close when the user hovers over it, the problem persisted. I thoroughly reviewed all the code related to time handling to ensure that wasn't the problem.
Changes Made:

Added Close Button: Introduced a close button to the notification for more explicit user control.

Cosmetic Improvement: Made the notification slightly transparent for a better visual appeal.

These changes should enhance user experience by providing a clear way to dismiss notifications and a more polished look.

Here is a screenshot of it:

Please review and merge if everything looks good. Thank you!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/478 **Author:** [@SO9010](https://github.com/SO9010) **Created:** 6/12/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `feature/rework-ui` --- ### 📝 Commits (2) - [`d7e89ed`](https://github.com/jpochyla/psst/commit/d7e89ed804aa141edce91c528cc3825c35d4ba9e) Add close button to alerts - [`9d9acb1`](https://github.com/jpochyla/psst/commit/9d9acb1a61bbe154ca19110d88fe3b0ad7f14f1b) Merge branch 'jpochyla:master' into feature/rework-ui ### 📊 Changes **2 files changed** (+17 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `psst-gui/src/ui/mod.rs` (+10 -2) 📝 `psst-gui/src/widget/icons.rs` (+7 -0) </details> ### 📄 Description This merge request partially addresses issue #255, which I believe stems from an upstream issue. After exploring several solutions, including making the notification close when the user hovers over it, the problem persisted. I thoroughly reviewed all the code related to time handling to ensure that wasn't the problem. Changes Made: Added Close Button: Introduced a close button to the notification for more explicit user control. Cosmetic Improvement: Made the notification slightly transparent for a better visual appeal. These changes should enhance user experience by providing a clear way to dismiss notifications and a more polished look. Here is a screenshot of it: ![image](https://github.com/jpochyla/psst/assets/77629938/e22b8263-c8ba-4e30-8ffd-fd3c7f7363d4) Please review and merge if everything looks good. Thank you! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>