[PR #411] [MERGED] Split playlist & control section #528

Closed
opened 2026-02-28 14:33:20 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/411
Author: @jacksongoode
Created: 5/10/2023
Status: Merged
Merged: 5/10/2023
Merged by: @Insprill

Base: masterHead: jackson/controls-spacing


📝 Commits (6)

  • 25b5cad Initial draft
  • b4150d5 Adjust spacing and center
  • cca8c3d Double min window height to avoid overlap
  • 55ac0f8 Revert to stacking columns, bump height
  • 5400f09 Set to height allowing one playlist
  • 980d422 Bump to 50

📊 Changes

2 files changed (+19 additions, -8 deletions)

View changed files

📝 psst-gui/src/ui/mod.rs (+17 -6)
📝 psst-gui/src/ui/user.rs (+2 -2)

📄 Description

This adds proper spacing between the volume control and divider and splits the playlist section and volume/controls section to provide a divider.

Here an image of this PR (left) and before (right):

Screen Shot 2023-05-09 at 9 00 42 PM

This also:

  • Reduces padding around gear
  • Increases the minimum height of window so that playlists can be visible at min height

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/411 **Author:** [@jacksongoode](https://github.com/jacksongoode) **Created:** 5/10/2023 **Status:** ✅ Merged **Merged:** 5/10/2023 **Merged by:** [@Insprill](https://github.com/Insprill) **Base:** `master` ← **Head:** `jackson/controls-spacing` --- ### 📝 Commits (6) - [`25b5cad`](https://github.com/jpochyla/psst/commit/25b5cad210e075c9d553fc7fdbffaaefa6b1e6d8) Initial draft - [`b4150d5`](https://github.com/jpochyla/psst/commit/b4150d5f678009c668326a7baec22b91386df975) Adjust spacing and center - [`cca8c3d`](https://github.com/jpochyla/psst/commit/cca8c3d349fc111e291c250d06ad97712ec48273) Double min window height to avoid overlap - [`55ac0f8`](https://github.com/jpochyla/psst/commit/55ac0f8335d3142ea60da41d20f81232979e3dfa) Revert to stacking columns, bump height - [`5400f09`](https://github.com/jpochyla/psst/commit/5400f091cf73adff0400df489f95edc9b318f747) Set to height allowing one playlist - [`980d422`](https://github.com/jpochyla/psst/commit/980d42297f37c95bbca0c179061d199ff19a87ac) Bump to 50 ### 📊 Changes **2 files changed** (+19 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `psst-gui/src/ui/mod.rs` (+17 -6) 📝 `psst-gui/src/ui/user.rs` (+2 -2) </details> ### 📄 Description This adds proper spacing between the volume control and divider and splits the playlist section and volume/controls section to provide a divider. Here an image of this PR (left) and before (right): <img width="500" alt="Screen Shot 2023-05-09 at 9 00 42 PM" src="https://github.com/jpochyla/psst/assets/54308792/b1c9aa1d-40a4-4f52-9ab0-949a384b5155"> This also: - Reduces padding around gear - Increases the minimum height of window so that playlists can be visible at min height --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 14:33:20 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/psst#528
No description provided.