[PR #379] [MERGED] Safer error-handling mechanism #505

New issue

Closed

opened 2026-02-28 14:33:15 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:33:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/379
Author: @arch-btw
Created: 3/17/2023
Status: ✅ Merged
Merged: 3/22/2023
Merged by: @Insprill

Base: master ← Head: patch-1

📝 Commits (3)

df0de38 Safer error-handling mechanism
c791d3c Update playback.rs
728978b Update playback.rs

📊 Changes

1 file changed (+5 additions, -1 deletions)

View changed files

📝 psst-gui/src/controller/playback.rs (+5 -1)

📄 Description

Hi, this is my first time writing Rust, please go easy on me 🙂 Could you make sure I did it correct? I won't be offended if it's not any good. This error was I think similar to the one found in https://github.com/jpochyla/psst/pull/374

The error was as follows and it would cause the app to crash and shutdown:

thread 'main' panicked at 'called Result::unwrap() on an Err value: "SendError(..)"', psst-gui/src/controller/playback.rs:219:51

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/379 **Author:** [@arch-btw](https://github.com/arch-btw) **Created:** 3/17/2023 **Status:** ✅ Merged **Merged:** 3/22/2023 **Merged by:** [@Insprill](https://github.com/Insprill) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (3) - [`df0de38`](https://github.com/jpochyla/psst/commit/df0de38e7a87d4faf7241e36479c7453b34038d4) Safer error-handling mechanism - [`c791d3c`](https://github.com/jpochyla/psst/commit/c791d3c13f00def43892f542d5e392423963ca21) Update playback.rs - [`728978b`](https://github.com/jpochyla/psst/commit/728978bf268c08e67bcb3baf9323a9183c526dc5) Update playback.rs ### 📊 Changes **1 file changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `psst-gui/src/controller/playback.rs` (+5 -1) </details> ### 📄 Description Hi, this is my first time writing Rust, please go easy on me 🙂 Could you make sure I did it correct? I won't be offended if it's not any good. This error was I think similar to the one found in https://github.com/jpochyla/psst/pull/374 The error was as follows and it would cause the app to crash and shutdown: > thread 'main' panicked at 'called Result::unwrap() on an Err value: "SendError(..)"', psst-gui/src/controller/playback.rs:219:51 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>