[PR #344] [MERGED] Quit app when the main window is closed #491

New issue

Closed

opened 2026-02-28 14:33:12 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:33:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/344
Author: @Insprill
Created: 10/8/2022
Status: ✅ Merged
Merged: 10/12/2022
Merged by: @jpochyla

Base: master ← Head: fix/249

📝 Commits (1)

fde3b98 Quit app when the main window is closed

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 psst-gui/src/delegate.rs (+3 -2)

📄 Description

Ensures all child windows are closed and the app closes when the main window is closed. Fixes #249.
I currently call the CLOSE_ALL_WINDOWS and QUIT_APP commands because on Windows the QUIT_APP command takes a while to actually quit, and I'm not sure if CLOSE_ALL_WINDOWS works the same way on other platforms as it does Windows. Testing on other platforms to see if both are necessary would be appreciated!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/344 **Author:** [@Insprill](https://github.com/Insprill) **Created:** 10/8/2022 **Status:** ✅ Merged **Merged:** 10/12/2022 **Merged by:** [@jpochyla](https://github.com/jpochyla) **Base:** `master` ← **Head:** `fix/249` --- ### 📝 Commits (1) - [`fde3b98`](https://github.com/jpochyla/psst/commit/fde3b9870bc93a6b987fd6674d5f7e298638b092) Quit app when the main window is closed ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `psst-gui/src/delegate.rs` (+3 -2) </details> ### 📄 Description Ensures all child windows are closed and the app closes when the main window is closed. Fixes #249. I currently call the `CLOSE_ALL_WINDOWS` and `QUIT_APP` commands because on Windows the `QUIT_APP` command takes a while to actually quit, and I'm not sure if `CLOSE_ALL_WINDOWS` works the same way on other platforms as it does Windows. Testing on other platforms to see if both are necessary would be appreciated! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>