[PR #339] [MERGED] Add logarithmic volume scaling #488

Closed
opened 2026-02-28 14:33:11 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/339
Author: @clin045
Created: 9/27/2022
Status: Merged
Merged: 9/29/2022
Merged by: @jpochyla

Base: masterHead: log_volume


📝 Commits (1)

  • ae027e5 Add approximate volume scaling

📊 Changes

1 file changed (+4 additions, -2 deletions)

View changed files

📝 psst-core/src/audio/output/cpal.rs (+4 -2)

📄 Description

Implement volume scaling (https://github.com/jpochyla/psst/issues/336). Instead of actually calculating the logarithm, I just used x^4 which is a good approximation suggested here.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/339 **Author:** [@clin045](https://github.com/clin045) **Created:** 9/27/2022 **Status:** ✅ Merged **Merged:** 9/29/2022 **Merged by:** [@jpochyla](https://github.com/jpochyla) **Base:** `master` ← **Head:** `log_volume` --- ### 📝 Commits (1) - [`ae027e5`](https://github.com/jpochyla/psst/commit/ae027e5f48cb9f4939b99622d210c42e33c7f309) Add approximate volume scaling ### 📊 Changes **1 file changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `psst-core/src/audio/output/cpal.rs` (+4 -2) </details> ### 📄 Description Implement volume scaling (https://github.com/jpochyla/psst/issues/336). Instead of actually calculating the logarithm, I just used x^4 which is a good approximation suggested [here](https://www.dr-lex.be/info-stuff/volumecontrols.html). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 14:33:11 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/psst#488
No description provided.