[PR #341] [MERGED] Clear credentials from UI after authenticating #487

New issue

Closed

opened 2026-02-28 14:33:11 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:33:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/341
Author: @Insprill
Created: 10/8/2022
Status: ✅ Merged
Merged: 1/11/2023
Merged by: @Insprill

Base: master ← Head: fix/credentials

📝 Commits (5)

27217c6 Clear credentials from UI after authenticating
2d966af Clear credentials last
a8173cd Merge branch 'jpochyla:master' into fix/credentials
0b3badc Don't clear username if authentication fails
81bf88d Clear login credentials when prefrences window is closed

📊 Changes

3 files changed (+10 additions, -0 deletions)

View changed files

📝 psst-gui/src/data/config.rs (+5 -0)
📝 psst-gui/src/delegate.rs (+1 -0)
📝 psst-gui/src/ui/preferences.rs (+4 -0)

📄 Description

When logging in initially, or after changing accounts, until psst is restarted, when the settings panel is opened, the credentials will be visible in plain text. This clears the credentials from the UI after a login attempt, no matter if it's successful or not.

If #342 gets merged then perhaps this should only clear the credentials if authentication was successful?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/341 **Author:** [@Insprill](https://github.com/Insprill) **Created:** 10/8/2022 **Status:** ✅ Merged **Merged:** 1/11/2023 **Merged by:** [@Insprill](https://github.com/Insprill) **Base:** `master` ← **Head:** `fix/credentials` --- ### 📝 Commits (5) - [`27217c6`](https://github.com/jpochyla/psst/commit/27217c6fe658c6bf7cec0eabcae4030ee63d334a) Clear credentials from UI after authenticating - [`2d966af`](https://github.com/jpochyla/psst/commit/2d966afb0a13ae7af9d2c44a6d05b49eb0587d1f) Clear credentials last - [`a8173cd`](https://github.com/jpochyla/psst/commit/a8173cd579ca507fd71fbf9ef37182d59f73c699) Merge branch 'jpochyla:master' into fix/credentials - [`0b3badc`](https://github.com/jpochyla/psst/commit/0b3badc3b5535a4baf909f98e14abc940b0d218c) Don't clear username if authentication fails - [`81bf88d`](https://github.com/jpochyla/psst/commit/81bf88d8a90923a9842c38dbbf4d4abf273dd753) Clear login credentials when prefrences window is closed ### 📊 Changes **3 files changed** (+10 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `psst-gui/src/data/config.rs` (+5 -0) 📝 `psst-gui/src/delegate.rs` (+1 -0) 📝 `psst-gui/src/ui/preferences.rs` (+4 -0) </details> ### 📄 Description When logging in initially, or after changing accounts, until psst is restarted, when the settings panel is opened, the credentials will be visible in plain text. This clears the credentials from the UI after a login attempt, no matter if it's successful or not. If #342 gets merged then perhaps this should only clear the credentials if authentication was successful? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>