[PR #330] [MERGED] Chunk fetching no longer requires 4-byte alignment #482

New issue

Closed

opened 2026-02-28 14:33:10 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:33:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/330
Author: @luukvanderduim
Created: 8/23/2022
Status: ✅ Merged
Merged: 9/22/2022
Merged by: @jpochyla

Base: master ← Head: remove_aligned_reads

📝 Commits (1)

5f698d2 Chunk fetching no longer requires 4-byte alignment

📊 Changes

1 file changed (+3 additions, -12 deletions)

View changed files

📝 psst-core/src/player/storage.rs (+3 -12)

📄 Description

As learned in discussion #308, Psst no longer require 4-byte alignment on fetching data chunks.

This removes functions round_down_to_multiple and round_up_to_multiple,
and adjusts the Read implementation for StreamReader accordingly.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/330 **Author:** [@luukvanderduim](https://github.com/luukvanderduim) **Created:** 8/23/2022 **Status:** ✅ Merged **Merged:** 9/22/2022 **Merged by:** [@jpochyla](https://github.com/jpochyla) **Base:** `master` ← **Head:** `remove_aligned_reads` --- ### 📝 Commits (1) - [`5f698d2`](https://github.com/jpochyla/psst/commit/5f698d2ea294db8870245be2a8153c30e6347462) Chunk fetching no longer requires 4-byte alignment ### 📊 Changes **1 file changed** (+3 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `psst-core/src/player/storage.rs` (+3 -12) </details> ### 📄 Description As learned in discussion #308, Psst no longer require 4-byte alignment on fetching data chunks. This removes functions `round_down_to_multiple` and `round_up_to_multiple`, and adjusts the `Read` implementation for `StreamReader` accordingly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>