[PR #282] [MERGED] very basic ico creation out of github actions #470

New issue

Closed

opened 2026-02-28 14:33:07 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:33:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/282
Author: @jacomago
Created: 2/25/2022
Status: ✅ Merged
Merged: 5/19/2022
Merged by: @jpochyla

Base: master ← Head: master

📝 Commits (4)

8e633a4 very basic ico creation out of github actions
76c49fe remove ico
2b5de53 Use image-rs for ico creation
048a345 Made extra functions applicable only to windows

📊 Changes

5 files changed (+334 additions, -28 deletions)

View changed files

📝 .github/workflows/build.yml (+0 -20)
📝 .gitignore (+1 -0)
📝 Cargo.lock (+294 -7)
📝 psst-gui/Cargo.toml (+1 -0)
📝 psst-gui/build.rs (+38 -1)

📄 Description

To fix #259

Note I didn't add all of the other variations of resolution and color sizes, since from ico format history it seems that from Windows Vista resolution: 256x256 is supported with all colors. Also that is the point at which png are supported, so I don't think smaller icons are necessary.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/282 **Author:** [@jacomago](https://github.com/jacomago) **Created:** 2/25/2022 **Status:** ✅ Merged **Merged:** 5/19/2022 **Merged by:** [@jpochyla](https://github.com/jpochyla) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (4) - [`8e633a4`](https://github.com/jpochyla/psst/commit/8e633a4452ed4d9c6bf4c22e3af70c40aa1676f3) very basic ico creation out of github actions - [`76c49fe`](https://github.com/jpochyla/psst/commit/76c49fe35518cc6b4c63164dcc3a14d6012e727f) remove ico - [`2b5de53`](https://github.com/jpochyla/psst/commit/2b5de5342093d48a39d541a258b21755ab549c02) Use image-rs for ico creation - [`048a345`](https://github.com/jpochyla/psst/commit/048a34572156118049d665b452f529d81ec2ff5a) Made extra functions applicable only to windows ### 📊 Changes **5 files changed** (+334 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yml` (+0 -20) 📝 `.gitignore` (+1 -0) 📝 `Cargo.lock` (+294 -7) 📝 `psst-gui/Cargo.toml` (+1 -0) 📝 `psst-gui/build.rs` (+38 -1) </details> ### 📄 Description To fix #259 Note I didn't add all of the other variations of resolution and color sizes, since from [ico format history](https://en.wikipedia.org/wiki/ICO_(file_format)) it seems that from Windows Vista resolution: 256x256 is supported with all colors. Also that is the point at which png are supported, so I don't think smaller icons are necessary. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>