[PR #266] [MERGED] feat: implement scrollable volume slider #468

Closed
opened 2026-02-28 14:33:07 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/266
Author: @charliethomson
Created: 1/19/2022
Status: Merged
Merged: 1/12/2023
Merged by: @Insprill

Base: masterHead: scrollable_volume


📝 Commits (5)

  • 60856af feat: implement scrollable volume slider
  • 2124aa9 cleanup: remove log statement
  • fc5c705 Merge branch 'master' into scrollable_volume
  • c7d9d4b Merge branch 'master' into scrollable_volume
  • f674917 Add scroll scale to config, make it more generic

📊 Changes

8 files changed (+149 additions, -6 deletions)

View changed files

psst-gui/src/controller/ex_scroll.rs (+62 -0)
📝 psst-gui/src/controller/mod.rs (+2 -0)
📝 psst-gui/src/data/config.rs (+3 -1)
📝 psst-gui/src/data/mod.rs (+2 -0)
psst-gui/src/data/slider_scroll_scale.rs (+30 -0)
📝 psst-gui/src/ui/mod.rs (+6 -0)
📝 psst-gui/src/ui/preferences.rs (+34 -3)
📝 psst-gui/src/widget/mod.rs (+10 -2)

📄 Description

From Spotify & YouTube, I missed scrolling to change the volume, so I implemented it. I added one field to the config
image
with defaults
image
image
You can also invert the scroll direction by making the x or y field negative


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/266 **Author:** [@charliethomson](https://github.com/charliethomson) **Created:** 1/19/2022 **Status:** ✅ Merged **Merged:** 1/12/2023 **Merged by:** [@Insprill](https://github.com/Insprill) **Base:** `master` ← **Head:** `scrollable_volume` --- ### 📝 Commits (5) - [`60856af`](https://github.com/jpochyla/psst/commit/60856af9293b23af566b0f0b04685ae024887f53) feat: implement scrollable volume slider - [`2124aa9`](https://github.com/jpochyla/psst/commit/2124aa9b74df2a6051a8b13e0ec6b3035c9a194c) cleanup: remove log statement - [`fc5c705`](https://github.com/jpochyla/psst/commit/fc5c7057ac3bc91978fac473c6d72a49a063d6f8) Merge branch 'master' into scrollable_volume - [`c7d9d4b`](https://github.com/jpochyla/psst/commit/c7d9d4be7b876da7157513010871e71253f1df8a) Merge branch 'master' into scrollable_volume - [`f674917`](https://github.com/jpochyla/psst/commit/f674917e96f1bcc59c4c4dac1dc113dfad7bf490) Add scroll scale to config, make it more generic ### 📊 Changes **8 files changed** (+149 additions, -6 deletions) <details> <summary>View changed files</summary> ➕ `psst-gui/src/controller/ex_scroll.rs` (+62 -0) 📝 `psst-gui/src/controller/mod.rs` (+2 -0) 📝 `psst-gui/src/data/config.rs` (+3 -1) 📝 `psst-gui/src/data/mod.rs` (+2 -0) ➕ `psst-gui/src/data/slider_scroll_scale.rs` (+30 -0) 📝 `psst-gui/src/ui/mod.rs` (+6 -0) 📝 `psst-gui/src/ui/preferences.rs` (+34 -3) 📝 `psst-gui/src/widget/mod.rs` (+10 -2) </details> ### 📄 Description From Spotify & YouTube, I missed scrolling to change the volume, so I implemented it. I added one field to the config ![image](https://user-images.githubusercontent.com/38197300/150230795-ea2d65e2-aeb3-467f-b142-6fd30e7fb0c8.png) with defaults ![image](https://user-images.githubusercontent.com/38197300/150230949-a504bf98-4b7b-431d-ac15-9a2e8e4352d0.png) ![image](https://user-images.githubusercontent.com/38197300/150231132-13f6990e-5e5a-4272-8352-245ee7b7d9ca.png) You can also invert the scroll direction by making the x or y field negative --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 14:33:07 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/psst#468
No description provided.