mirror of
https://github.com/jpochyla/psst.git
synced 2026-04-27 07:25:52 +03:00
[PR #266] [MERGED] feat: implement scrollable volume slider #468
Labels
No labels
api
bug
build
documentation
duplicate
enhancement
good first issue
help wanted
idea
invalid
linux
lowprio
macos
pull-request
upstream
windows
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/psst#468
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/jpochyla/psst/pull/266
Author: @charliethomson
Created: 1/19/2022
Status: ✅ Merged
Merged: 1/12/2023
Merged by: @Insprill
Base:
master← Head:scrollable_volume📝 Commits (5)
60856affeat: implement scrollable volume slider2124aa9cleanup: remove log statementfc5c705Merge branch 'master' into scrollable_volumec7d9d4bMerge branch 'master' into scrollable_volumef674917Add scroll scale to config, make it more generic📊 Changes
8 files changed (+149 additions, -6 deletions)
View changed files
➕
psst-gui/src/controller/ex_scroll.rs(+62 -0)📝
psst-gui/src/controller/mod.rs(+2 -0)📝
psst-gui/src/data/config.rs(+3 -1)📝
psst-gui/src/data/mod.rs(+2 -0)➕
psst-gui/src/data/slider_scroll_scale.rs(+30 -0)📝
psst-gui/src/ui/mod.rs(+6 -0)📝
psst-gui/src/ui/preferences.rs(+34 -3)📝
psst-gui/src/widget/mod.rs(+10 -2)📄 Description
From Spotify & YouTube, I missed scrolling to change the volume, so I implemented it. I added one field to the config



with defaults
You can also invert the scroll direction by making the x or y field negative
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.