[PR #261] [MERGED] Stop playback on stop command #466

New issue

Closed

opened 2026-02-28 14:33:07 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:33:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/261
Author: @forslund
Created: 1/16/2022
Status: ✅ Merged
Merged: 3/12/2022
Merged by: @jpochyla

Base: master ← Head: pause-on-stop

📝 Commits (1)

9805367 core: Stop audio_output_sink on stop command

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 psst-core/src/player/mod.rs (+1 -0)

📄 Description

Currently the audio playback continues when the stop command is received in the player. To me this was quite counter-intuitive, and I think the playback should stop directly.

This adds a call to self.audio_output_sink.stop() when the stop-command is received.

This can easily be tested using the cli-client where "s" will not do anything.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/261 **Author:** [@forslund](https://github.com/forslund) **Created:** 1/16/2022 **Status:** ✅ Merged **Merged:** 3/12/2022 **Merged by:** [@jpochyla](https://github.com/jpochyla) **Base:** `master` ← **Head:** `pause-on-stop` --- ### 📝 Commits (1) - [`9805367`](https://github.com/jpochyla/psst/commit/98053674f25327229133e48c2c2ede0f5ae65a7a) core: Stop audio_output_sink on stop command ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `psst-core/src/player/mod.rs` (+1 -0) </details> ### 📄 Description Currently the audio playback continues when the stop command is received in the player. To me this was quite counter-intuitive, and I think the playback should stop directly. This adds a call to `self.audio_output_sink.stop()` when the stop-command is received. This can easily be tested using the cli-client where "s" will not do anything. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>