mirror of
https://github.com/jpochyla/psst.git
synced 2026-04-27 07:25:52 +03:00
[PR #233] [MERGED] Add track cover art in playlist and search results #459
Labels
No labels
api
bug
build
documentation
duplicate
enhancement
good first issue
help wanted
idea
invalid
linux
lowprio
macos
pull-request
upstream
windows
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/psst#459
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/jpochyla/psst/pull/233
Author: @itsjunetime
Created: 12/11/2021
Status: ✅ Merged
Merged: 12/22/2021
Merged by: @jpochyla
Base:
master← Head:add_track_cover📝 Commits (3)
9494168Add option to show track covers alongside the name and album0596417Fixed regression with line and song length not appearing4ab747agui: Add config option for the track covers📊 Changes
6 files changed (+73 additions, -11 deletions)
View changed files
📝
psst-gui/src/data/config.rs(+2 -0)📝
psst-gui/src/data/mod.rs(+2 -0)📝
psst-gui/src/ui/playlist.rs(+1 -0)📝
psst-gui/src/ui/preferences.rs(+24 -2)📝
psst-gui/src/ui/search.rs(+1 -0)📝
psst-gui/src/ui/track.rs(+43 -9)📄 Description
This adds cover art images to tracks within playlists and search results (but not in albums), akin to the first party Spotify app (see attached image for a visual of what it looks like now). I didn't see an issue about this, but I feel it makes sense since that is what the spotify electron app does.
If you feel this is an unwanted change or should be implemented some other way, let me know and I'd be glad to discuss it :)
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.