[PR #229] [MERGED] chore: Build Windows ICO using ImageMagick #458

New issue

Closed

opened 2026-02-28 14:33:05 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:33:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/229
Author: @jstarpl
Created: 12/9/2021
Status: ✅ Merged
Merged: 12/10/2021
Merged by: @jpochyla

Base: master ← Head: fix/issue-227

📝 Commits (7)

7b4c2a3 fix: use ImageMagick to assemble a Windows ICO file
00c18d3 fix: use choco version of ImageMagick
b2ba0b8 chore: use working-directory
45df567 fix: use new way of setting PATH
714c393 fix: quite possibly an incorrectly formatted string was written to the GITHUB_PATH
e9ced49 fix: didn't understand what was an object and what was a string variable
38a991e fix: missing steps, wrong filename

📊 Changes

1 file changed (+20 additions, -0 deletions)

View changed files

📝 .github/workflows/build.yml (+20 -0)

📄 Description

This PR adds a step to use ImageMagick to build the Windows ICO file.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/229 **Author:** [@jstarpl](https://github.com/jstarpl) **Created:** 12/9/2021 **Status:** ✅ Merged **Merged:** 12/10/2021 **Merged by:** [@jpochyla](https://github.com/jpochyla) **Base:** `master` ← **Head:** `fix/issue-227` --- ### 📝 Commits (7) - [`7b4c2a3`](https://github.com/jpochyla/psst/commit/7b4c2a3c84cc3811aeabb2a9d2427ea4c30c2312) fix: use ImageMagick to assemble a Windows ICO file - [`00c18d3`](https://github.com/jpochyla/psst/commit/00c18d336df9acf3b29c1c00c6ea87491493e59d) fix: use choco version of ImageMagick - [`b2ba0b8`](https://github.com/jpochyla/psst/commit/b2ba0b8604f6d6112f9a1b5db57183b587eaab10) chore: use working-directory - [`45df567`](https://github.com/jpochyla/psst/commit/45df56795453a3cd5565e14d70eafbf0c322a271) fix: use new way of setting PATH - [`714c393`](https://github.com/jpochyla/psst/commit/714c39380f1e8b6feb48f13f16f17299c4b1346f) fix: quite possibly an incorrectly formatted string was written to the GITHUB_PATH - [`e9ced49`](https://github.com/jpochyla/psst/commit/e9ced495cfd4568221bc4e94ef3bb2605dba3f5f) fix: didn't understand what was an object and what was a string variable - [`38a991e`](https://github.com/jpochyla/psst/commit/38a991eb2a6b4bb0051a4f585f64e8ae9d52da3d) fix: missing steps, wrong filename ### 📊 Changes **1 file changed** (+20 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yml` (+20 -0) </details> ### 📄 Description This PR adds a step to use ImageMagick to build the Windows ICO file. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>