[PR #198] [CLOSED] Playlist Manipulation: Adding tracks to playlists #449

New issue

Closed

opened 2026-02-28 14:33:03 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:33:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/198
Author: @martingoe
Created: 10/14/2021
Status: ❌ Closed

Base: master ← Head: track-playlist-adding

📝 Commits (7)

f4b9ad9 Implement a to_uri function for item_ids.
327062d Implement a POST method in the webapi client.
38b3f0a Add an endpoint for adding a track to a playlist.
d83a654 Add a PublicUser struct and add an id value to UserProfile
4294be7 Implement an ADD_TRACK command for adding a track to a playlist.
a43611e Implement a way to get all owned playlists
8efb405 Add the needed UI to add a track to a playlist.

📊 Changes

7 files changed (+92 additions, -7 deletions)

View changed files

📝 psst-core/src/item_id.rs (+10 -0)
📝 psst-gui/src/data/mod.rs (+17 -1)
📝 psst-gui/src/data/playlist.rs (+9 -1)
📝 psst-gui/src/data/user.rs (+8 -0)
📝 psst-gui/src/ui/playlist.rs (+12 -1)
📝 psst-gui/src/ui/track.rs (+25 -4)
📝 psst-gui/src/webapi/client.rs (+11 -0)

📄 Description

As described in the commits, this PR is not quite ready to merge with the main project.

I believe the following problems should be discussed:
Commit 4294be7:

The current command executor for adding a track to a playlist is in the playlists list_widget function. This might not be the optimal position.
If the request failed, the user should be notified. I believe this could be done with an alert box, but I did not currently find a way to implement this.

Commit 8efb405:

The UI should be able to have access to the current user's ID without an API call.

Commit a43611e uses Vecs instead of the more commonly used Vector.

edit: I was unaware of the draft feature github has but I believe this works just as well.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/198 **Author:** [@martingoe](https://github.com/martingoe) **Created:** 10/14/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `track-playlist-adding` --- ### 📝 Commits (7) - [`f4b9ad9`](https://github.com/jpochyla/psst/commit/f4b9ad9d593fc78e14f84470c473e18d87b21624) Implement a to_uri function for item_ids. - [`327062d`](https://github.com/jpochyla/psst/commit/327062deb192f5e7725ead8f4c0d5dcb13d8990f) Implement a POST method in the webapi client. - [`38b3f0a`](https://github.com/jpochyla/psst/commit/38b3f0aeb7563381675b780f2b26cea8c15ebbc4) Add an endpoint for adding a track to a playlist. - [`d83a654`](https://github.com/jpochyla/psst/commit/d83a6547e2d743e53c8bc38bf301ca4e8ba02b7c) Add a PublicUser struct and add an id value to UserProfile - [`4294be7`](https://github.com/jpochyla/psst/commit/4294be7d96f9f9b9e815ef7e3f7d3301de6bc86c) Implement an ADD_TRACK command for adding a track to a playlist. - [`a43611e`](https://github.com/jpochyla/psst/commit/a43611e5d44938b985e18b43412046255ab386ad) Implement a way to get all owned playlists - [`8efb405`](https://github.com/jpochyla/psst/commit/8efb40597c4a5e5b15a279658fdd5252c148476d) Add the needed UI to add a track to a playlist. ### 📊 Changes **7 files changed** (+92 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `psst-core/src/item_id.rs` (+10 -0) 📝 `psst-gui/src/data/mod.rs` (+17 -1) 📝 `psst-gui/src/data/playlist.rs` (+9 -1) 📝 `psst-gui/src/data/user.rs` (+8 -0) 📝 `psst-gui/src/ui/playlist.rs` (+12 -1) 📝 `psst-gui/src/ui/track.rs` (+25 -4) 📝 `psst-gui/src/webapi/client.rs` (+11 -0) </details> ### 📄 Description As described in the commits, this PR is not quite ready to merge with the main project. I believe the following problems should be discussed: Commit 4294be7: - The current command executor for adding a track to a playlist is in the playlists `list_widget` function. This might not be the optimal position. - If the request failed, the user should be notified. I believe this could be done with an alert box, but I did not currently find a way to implement this. Commit 8efb405: - The UI should be able to have access to the current user's ID without an API call. Commit a43611e uses `Vec`s instead of the more commonly used `Vector`. edit: I was unaware of the draft feature github has but I believe this works just as well. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>