[PR #176] [MERGED] gui: Display album art in playback bar #447

New issue

Closed

opened 2026-02-28 14:33:02 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:33:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/176
Author: @brandly
Created: 9/14/2021
Status: ✅ Merged
Merged: 9/15/2021
Merged by: @jpochyla

Base: master ← Head: patch-1

📝 Commits (3)

627a704 gui: Display album art in playback bar
24e2713 gui: Fix NP cover image for album tracks
3b7d3e6 gui: Fix NP item overflow

📊 Changes

2 files changed (+31 additions, -12 deletions)

View changed files

📝 psst-gui/src/data/playback.rs (+8 -3)
📝 psst-gui/src/ui/playback.rs (+23 -9)

📄 Description

Hey, I'm Matt! This app is great. I want to learn more about how it all fits together. I saw this comment from @pythonhacker and figured I'd take a stab at it.

My changes here are fairly basic. I saw cover_widget functions defined in files like ui/artist.rs and followed suit. I thought filling the available space would look nice and somewhat similar to the Albums tab, but an alternative design would be with rounded corners and margins around the image similar to the Home tab. Let me know if you'd like me to change this!

The current code works in most situations. I can play from a playlist:

From my saved tracks:

From a Daily Mix:

But when I play from an album view, no album art is displayed:

Thanks for taking a look!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/176 **Author:** [@brandly](https://github.com/brandly) **Created:** 9/14/2021 **Status:** ✅ Merged **Merged:** 9/15/2021 **Merged by:** [@jpochyla](https://github.com/jpochyla) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (3) - [`627a704`](https://github.com/jpochyla/psst/commit/627a70433cd8054eb8526978af36ba370dc825c1) gui: Display album art in playback bar - [`24e2713`](https://github.com/jpochyla/psst/commit/24e27132493c5b844b35ca4ac5fa13babd345761) gui: Fix NP cover image for album tracks - [`3b7d3e6`](https://github.com/jpochyla/psst/commit/3b7d3e64538e5594a95b76a00f3a692eb52b3e01) gui: Fix NP item overflow ### 📊 Changes **2 files changed** (+31 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `psst-gui/src/data/playback.rs` (+8 -3) 📝 `psst-gui/src/ui/playback.rs` (+23 -9) </details> ### 📄 Description Hey, I'm Matt! This app is great. I want to learn more about how it all fits together. I saw [this comment](https://github.com/jpochyla/psst/issues/113#issuecomment-901996044) from @pythonhacker and figured I'd take a stab at it. My changes here are fairly basic. I saw `cover_widget` functions defined in files like `ui/artist.rs` and followed suit. I thought filling the available space would look nice and somewhat similar to the _Albums_ tab, but an alternative design would be with rounded corners and margins around the image similar to the _Home_ tab. Let me know if you'd like me to change this! The current code works in most situations. I can play from a playlist: <img width="950" alt="Screen Shot 2021-09-13 at 9 10 54 PM" src="https://user-images.githubusercontent.com/820696/133178516-150ff465-94ea-4908-937b-e44aceffe0d7.png"> From my saved tracks: <img width="946" alt="Screen Shot 2021-09-13 at 9 11 01 PM" src="https://user-images.githubusercontent.com/820696/133178519-af49bcc5-f8c7-4c44-8c9c-7d856c557115.png"> From a Daily Mix: <img width="946" alt="Screen Shot 2021-09-13 at 9 11 14 PM" src="https://user-images.githubusercontent.com/820696/133178520-4965653a-0818-429f-85b6-24a02e7bcfd2.png"> But when I play from an album view, no album art is displayed: <img width="939" alt="Screen Shot 2021-09-13 at 9 11 38 PM" src="https://user-images.githubusercontent.com/820696/133178522-88990aed-8716-4521-adeb-96d08b5507f7.png"> Thanks for taking a look! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>