[PR #120] [MERGED] Fix wrong expiration time parsing #434

New issue

Closed

opened 2026-02-28 14:32:59 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:32:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/120
Author: @JuliDi
Created: 8/19/2021
Status: ✅ Merged
Merged: 8/20/2021
Merged by: @jpochyla

Base: master ← Head: fix-expiration-time

📝 Commits (2)

bcb56df fix wrong expiration time parsing
cfd83c2 core: Combine URL expiration parsing

📊 Changes

1 file changed (+16 additions, -5 deletions)

View changed files

📝 psst-core/src/cdn.rs (+16 -5)

📄 Description

The parsing of the expiration time seems to be wrong (probably outdated?), giving me a failed to parse expiration time from URL ... warning.

Not sure whether these server responses can differ across operating systems or so. At least building from master on macOS 10.15 I get a response of the form .../...a35817ca410?__token__=exp=1629466995~hmac=df348....

With the changes in this PR, the issue seems fixed – the log says that a new token has been requested because it was outdated.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/120 **Author:** [@JuliDi](https://github.com/JuliDi) **Created:** 8/19/2021 **Status:** ✅ Merged **Merged:** 8/20/2021 **Merged by:** [@jpochyla](https://github.com/jpochyla) **Base:** `master` ← **Head:** `fix-expiration-time` --- ### 📝 Commits (2) - [`bcb56df`](https://github.com/jpochyla/psst/commit/bcb56df41dcadd34f03649a7c30f3a27602e59af) fix wrong expiration time parsing - [`cfd83c2`](https://github.com/jpochyla/psst/commit/cfd83c2bdf407b71c2f242817889378e1cf8965f) core: Combine URL expiration parsing ### 📊 Changes **1 file changed** (+16 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `psst-core/src/cdn.rs` (+16 -5) </details> ### 📄 Description The parsing of the expiration time seems to be wrong (probably outdated?), giving me a `failed to parse expiration time from URL ...` warning. Not sure whether these server responses can differ across operating systems or so. At least building from master on macOS 10.15 I get a response of the form `.../...a35817ca410?__token__=exp=1629466995~hmac=df348...`. With the changes in this PR, the issue seems fixed – the log says that a new token has been requested because it was outdated. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>