mirror of
https://github.com/jpochyla/psst.git
synced 2026-04-27 07:25:52 +03:00
[PR #108] [MERGED] Add cmd+h for hide and ctrl+space for pause/resume #430
Labels
No labels
api
bug
build
documentation
duplicate
enhancement
good first issue
help wanted
idea
invalid
linux
lowprio
macos
pull-request
upstream
windows
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/psst#430
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/jpochyla/psst/pull/108
Author: @JuliDi
Created: 8/18/2021
Status: ✅ Merged
Merged: 8/18/2021
Merged by: @jpochyla
Base:
master← Head:add-more-hotkeys📝 Commits (2)
0e6a3f7Add cmd+h for hide and ctrl+space for pause/resumed108540revert ctrl+space for pause📊 Changes
1 file changed (+5 additions, -0 deletions)
View changed files
📝
psst-gui/src/ui/menu.rs(+5 -0)📄 Description
This should fix #91 in parts, but has a little drawback: you need to press ctrl+space to pause/resume the song.
I could not get the application to react to a normal key even without a modifier (i.e. only pressing space or another key when the psst window is open).
If there is a way to achieve this, I'd be happy to make the according changes.
In case #103 should be implemented (ctrl+w sends druid's
command::CLOSE_WINDOW), I could add that as well.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.