[PR #79] [CLOSED] Icon #421

New issue

Closed

opened 2026-02-28 14:32:57 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:32:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/79
Author: @Kethku
Created: 7/17/2021
Status: ❌ Closed

Base: master ← Head: icon

📝 Commits (2)

4d038be don't show console on windows machines when running release builds
b472758 create icon and add build script to add it to windows executable

📊 Changes

6 files changed (+68 additions, -1 deletions)

View changed files

📝 Cargo.lock (+10 -0)
📝 psst-gui/Cargo.toml (+5 -1)
➕ psst-gui/assets/logo.ico (+0 -0)
➕ psst-gui/assets/logo.svg (+44 -0)
➕ psst-gui/build.rs (+8 -0)
📝 psst-gui/src/main.rs (+1 -0)

📄 Description

Addresses part of https://github.com/jpochyla/psst/issues/74

Turns out druid doesn't yet have support for setting the window icon https://github.com/linebender/druid/issues/1162 so this PR just creates an icon from the logo svg path already present in this app and the spotify colors. It also introduces a build script in order to set the icon for the app exe on windows. Doing similar for other platforms will require more work that I don't know how to do.

Here is the icon I added:

This is obviously just a first pass, feel free to take it or leave it. Just figured I'd get the ball rolling.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/79 **Author:** [@Kethku](https://github.com/Kethku) **Created:** 7/17/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `icon` --- ### 📝 Commits (2) - [`4d038be`](https://github.com/jpochyla/psst/commit/4d038be8dac4401b2c97eebfdbe3ec02734724fe) don't show console on windows machines when running release builds - [`b472758`](https://github.com/jpochyla/psst/commit/b4727588882e5d88718d385cd32bf637ce3cdbe1) create icon and add build script to add it to windows executable ### 📊 Changes **6 files changed** (+68 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+10 -0) 📝 `psst-gui/Cargo.toml` (+5 -1) ➕ `psst-gui/assets/logo.ico` (+0 -0) ➕ `psst-gui/assets/logo.svg` (+44 -0) ➕ `psst-gui/build.rs` (+8 -0) 📝 `psst-gui/src/main.rs` (+1 -0) </details> ### 📄 Description Addresses part of https://github.com/jpochyla/psst/issues/74 Turns out druid doesn't yet have support for setting the window icon https://github.com/linebender/druid/issues/1162 so this PR just creates an icon from the logo svg path already present in this app and the spotify colors. It also introduces a build script in order to set the icon for the app exe on windows. Doing similar for other platforms will require more work that I don't know how to do. Here is the icon I added: ![logo-0](https://user-images.githubusercontent.com/3323631/126051162-19098380-4b04-47d6-9610-ddede527e206.png) This is obviously just a first pass, feel free to take it or leave it. Just figured I'd get the ball rolling. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>