[PR #56] [MERGED] Implement initial volume slider #418

New issue

Closed

opened 2026-02-28 14:32:56 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:32:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/56
Author: @ghost
Created: 5/27/2021
Status: ✅ Merged
Merged: 5/28/2021
Merged by: @jpochyla

Base: master ← Head: volume-control

📝 Commits (2)

74c9bc8 Implement volume slider
ac31fe0 Minor fixes and improvements for the volume code

📊 Changes

6 files changed (+76 additions, -6 deletions)

View changed files

📝 psst-core/src/audio_output.rs (+20 -3)
📝 psst-core/src/audio_player.rs (+9 -0)
📝 psst-gui/src/controller/playback.rs (+18 -0)
📝 psst-gui/src/data/mod.rs (+1 -0)
📝 psst-gui/src/data/playback.rs (+1 -0)
📝 psst-gui/src/ui/mod.rs (+27 -3)

📄 Description

This pull requests implements a working version of a volume slider. It was one of the pain points when using the application :D. As I was unsure about the location, I just put it somewhere where it could be easily accessed and thus not intrude on the rest of the application.

The slider allows values between 0 - 100 and displays the values as integer in the label (but is chosen as f32).

Image of the sidebar

I so far had no issues with it and it seems to perform well.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/56 **Author:** [@ghost](https://github.com/ghost) **Created:** 5/27/2021 **Status:** ✅ Merged **Merged:** 5/28/2021 **Merged by:** [@jpochyla](https://github.com/jpochyla) **Base:** `master` ← **Head:** `volume-control` --- ### 📝 Commits (2) - [`74c9bc8`](https://github.com/jpochyla/psst/commit/74c9bc822feb0807769f23812df66af7636fcff4) Implement volume slider - [`ac31fe0`](https://github.com/jpochyla/psst/commit/ac31fe050aa01aa3cf6e711d457ecde59c0f40b6) Minor fixes and improvements for the volume code ### 📊 Changes **6 files changed** (+76 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `psst-core/src/audio_output.rs` (+20 -3) 📝 `psst-core/src/audio_player.rs` (+9 -0) 📝 `psst-gui/src/controller/playback.rs` (+18 -0) 📝 `psst-gui/src/data/mod.rs` (+1 -0) 📝 `psst-gui/src/data/playback.rs` (+1 -0) 📝 `psst-gui/src/ui/mod.rs` (+27 -3) </details> ### 📄 Description This pull requests implements a working version of a volume slider. It was one of the pain points when using the application :D. As I was unsure about the location, I just put it somewhere where it could be easily accessed and thus not intrude on the rest of the application. The slider allows values between 0 - 100 and displays the values as integer in the label (but is chosen as f32). <details> <summary>Image of the sidebar</summary> ![screen](https://user-images.githubusercontent.com/35100156/119901182-dc069680-bf45-11eb-9f0b-165bf79c7ce7.png) </details> I so far had no issues with it and it seems to perform well. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>