[PR #25] [CLOSED] [WIP] Random and Loop controls #407

New issue

Closed

opened 2026-02-28 14:32:54 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:32:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/25
Author: @reynn
Created: 1/20/2021
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (2)

313fe88 Working towards shuffle and looping playback modes
9be6fd8 remove icons, buttons visibility fix, cleanup

📊 Changes

7 files changed (+183 additions, -17 deletions)

View changed files

📝 Cargo.lock (+65 -13)
📝 psst-core/src/audio_player.rs (+70 -4)
📝 psst-gui/Cargo.toml (+1 -0)
📝 psst-gui/src/cmd.rs (+2 -0)
📝 psst-gui/src/delegate.rs (+4 -0)
📝 psst-gui/src/ui/playback.rs (+30 -0)
📝 psst-gui/src/widget/icons.rs (+11 -0)

📄 Description

First pass at implementing random and looping to the project.

this is really rough right now and currently is only configurable in code. I have some ideas on where to go from here but would like some feedback.

remove the QueueBehavior struct from queue and instead have the next/previous methods of queue accept the QueueBehavior instead, then having the behavior be part of the PlayerDelegate in the GUI.
PlayerDelegate has a player_queue but it is currently a vec, this could potentially be changed to the Queue struct in core/audio_player.

I'm sure I could have missed stuff since I am still learning the code base, if there is a better way you think this could be accomplished I'm happy to hear them :)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/25 **Author:** [@reynn](https://github.com/reynn) **Created:** 1/20/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`313fe88`](https://github.com/jpochyla/psst/commit/313fe88b8982c600098cdfcff0e141a52aca68dc) Working towards shuffle and looping playback modes - [`9be6fd8`](https://github.com/jpochyla/psst/commit/9be6fd81023d4e9deeae6fdddb542a3bedfdb2fa) remove icons, buttons visibility fix, cleanup ### 📊 Changes **7 files changed** (+183 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+65 -13) 📝 `psst-core/src/audio_player.rs` (+70 -4) 📝 `psst-gui/Cargo.toml` (+1 -0) 📝 `psst-gui/src/cmd.rs` (+2 -0) 📝 `psst-gui/src/delegate.rs` (+4 -0) 📝 `psst-gui/src/ui/playback.rs` (+30 -0) 📝 `psst-gui/src/widget/icons.rs` (+11 -0) </details> ### 📄 Description First pass at implementing random and looping to the project. this is really rough right now and currently is only configurable in code. I have some ideas on where to go from here but would like some feedback. 1. remove the QueueBehavior struct from queue and instead have the next/previous methods of queue accept the QueueBehavior instead, then having the behavior be part of the PlayerDelegate in the GUI. 2. PlayerDelegate has a player_queue but it is currently a vec, this could potentially be changed to the Queue struct in core/audio_player. I'm sure I could have missed stuff since I am still learning the code base, if there is a better way you think this could be accomplished I'm happy to hear them :) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>