mirror of
https://github.com/jpochyla/psst.git
synced 2026-04-27 07:25:52 +03:00
[GH-ISSUE #695] Don't read git config in build.rs #391
Labels
No labels
api
bug
build
documentation
duplicate
enhancement
good first issue
help wanted
idea
invalid
linux
lowprio
macos
pull-request
upstream
windows
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/psst#391
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @colemickens on GitHub (Sep 25, 2025).
Original GitHub issue: https://github.com/jpochyla/psst/issues/695
Describe the bug
I find it very inappropriate that psst-core's
build.rsis... reading the git configuration.We have to patch this in nixpkgs, and I'm glad that we do. It would be great to not have to carry a patch and manually rebase it constantly because of the choices to try to embed this information in the binary, in this way.
To Reproduce
see: https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/ps/psst/make-build-reproducible.patch
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment
Additional context
Add any other context about the problem here.
@colemickens commented on GitHub (Sep 25, 2025):
By the way, I hit this when trying to test the auth fixes.
@jacksongoode commented on GitHub (Sep 25, 2025):
I see, we read it just to get the build commit sha. Would there be another way you'd suggest that would be more preferable so this info can be kept?
@colemickens commented on GitHub (Sep 25, 2025):
So, I think there's a method we can do to provide a "fake-git" to the package so that some things will work, but I'm not sure that will include the origin the way the build script expects it.
I'll dig in and send a patch when I figure out the least disruptive change on both sides.
Thanks for the quick reply!
@kingosticks commented on GitHub (Sep 25, 2025):
Have you looked at https://github.com/rustyhorde/vergen/ ? I think it leaves a placeholder in the values when they are unavailable due to missing git dir.