starred/psst

Fork 0

mirror of https://github.com/jpochyla/psst.git synced 2026-04-27 15:35:56 +03:00

[GH-ISSUE #624] Add URL encoding to search #364

New issue

Closed

opened 2026-02-28 14:32:29 +03:00 by kerem · 6 comments

kerem commented

2026-02-28 14:32:29 +03:00

Owner

Originally created by @SO9010 on GitHub (Jun 9, 2025).
Original GitHub issue: https://github.com/jpochyla/psst/issues/624

Currently, we are just using a placeholder to replace the spaces in a query but it needs to changed to use URL encoding.

Originally created by @SO9010 on GitHub (Jun 9, 2025). Original GitHub issue: https://github.com/jpochyla/psst/issues/624 Currently, we are just using a placeholder to replace the spaces in a query but it needs to changed to use URL encoding.

kerem

2026-02-28 14:32:29 +03:00

closed this issue
added the
bug

help wanted

good first issue
labels

kerem commented

2026-02-28 14:32:30 +03:00

Author

Owner

@arch-btw commented on GitHub (Jun 11, 2025):

Hmm, do you mean that this line needs to be improved upon, or are you referring to something else?

github.com/jpochyla/psst@0e9c8d0283/psst-gui/src/webapi/client.rs (L1351)

@arch-btw commented on GitHub (Jun 11, 2025): Hmm, do you mean that this line needs to be improved upon, or are you referring to something else? https://github.com/jpochyla/psst/blob/0e9c8d0283ced2c453aafa836be16de9fd51e48c/psst-gui/src/webapi/client.rs#L1351

kerem commented

2026-02-28 14:32:30 +03:00

Author

Owner

@SO9010 commented on GitHub (Jun 11, 2025):

Yeah that line!

@SO9010 commented on GitHub (Jun 11, 2025): Yeah that line!

kerem commented

2026-02-28 14:32:30 +03:00

Author

Owner

@secondlnl commented on GitHub (Jun 12, 2025):

Sorry for probably being slow, but why does it need improving.

@secondlnl commented on GitHub (Jun 12, 2025): Sorry for probably being slow, but why does it need improving.

kerem commented

2026-02-28 14:32:30 +03:00

Author

Owner

@SO9010 commented on GitHub (Jun 12, 2025):

I believe that if we don't do url encoding then we will get errors from illegal characters in urls. Which is why we needed to replace the spaces with %20. But I believe that we also need to do things like ':'.

But it was just a quick submitted issue that I didn't 100 percent check.

So if you would like to you could check if a query with something like : or any other not allowed chars in a url please feel free to do so. If not I'll be able to test soon :)

@SO9010 commented on GitHub (Jun 12, 2025): I believe that if we don't do url encoding then we will get errors from illegal characters in urls. Which is why we needed to replace the spaces with %20. But I believe that we also need to do things like ':'. But it was just a quick submitted issue that I didn't 100 percent check. So if you would like to you could check if a query with something like : or any other not allowed chars in a url please feel free to do so. If not I'll be able to test soon :)

kerem commented

2026-02-28 14:32:30 +03:00

Author

Owner

@secondlnl commented on GitHub (Jun 12, 2025):

Edit: There exists a crate called urlencoding, link to docs.rs, rust discourse discussion about urlencoding in general
Tested:
Invalid uri
" < >
Status 400
# ` \ | % & { } + ^ ; €
The plus symbol is okay as long as there's another character, errors only when alone.
Others tested:
! @ £ $ ¤ / ( ) [ ] = ? ´ ¨ ~ * ' : . , _ - µ

@secondlnl commented on GitHub (Jun 12, 2025): Edit: There exists a [crate called urlencoding, link to docs.rs](https://docs.rs/urlencoding/latest/urlencoding/), [rust discourse discussion about urlencoding in general](https://users.rust-lang.org/t/encode-decode-uri/90017/3) Tested: Invalid uri " < > Status 400 \# ` \ | % & { } + ^ ; € The plus symbol is okay as long as there's another character, errors only when alone. Others tested: ! @ £ $ ¤ / ( ) [ ] = ? ´ ¨ ~ * ' : . , _ - µ

kerem commented

2026-02-28 14:32:30 +03:00

Author

Owner

@SO9010 commented on GitHub (Jun 12, 2025):

Wow thank you very much! For the detailed test!
And that crate sounds good to me!

@SO9010 commented on GitHub (Jun 12, 2025): Wow thank you very much! For the detailed test! And that crate sounds good to me!

kerem referenced this issue

2026-02-28 14:33:14 +03:00

[PR #364] [MERGED] Update CI workflow #500