mirror of
https://github.com/jpochyla/psst.git
synced 2026-04-27 07:25:52 +03:00
[GH-ISSUE #598] First config save defaults when closing app #356
Labels
No labels
api
bug
build
documentation
duplicate
enhancement
good first issue
help wanted
idea
invalid
linux
lowprio
macos
pull-request
upstream
windows
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/psst#356
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @marcfusch on GitHub (Apr 18, 2025).
Original GitHub issue: https://github.com/jpochyla/psst/issues/598
Describe the bug
When starting from a fresh config.json, after logging in / modifying settings, the config.json file resets if the app is closed normally (clicking the cross). After restarting, the app now loads the default config that was critten just before closure.
In order to save my settings, I have to force close the app / terminate process. Only after that, if I close the app normaly, the config.json stays the same.
Note: This affects everything from Theme to lastfm auth EXCEPT spotify auth.
To Reproduce
Expected behavior
The config should not be cleared after first modification if the app is closed normally
Environment
Additional context
I just built psst release from main after the merge of lastfm_wip and deleted my config file to try.
@future10se commented on GitHub (Apr 19, 2025):
Hi, I can confirm this happens to me too, with some differences in behavior. I always have to force quit for prefs to save.
I set up a new MacBook Air M1 with a fresh install of macOS Sequoia 15.2, and installed Psst from the latest auto-build in the README.
I logged in and set up the preferences via the GUI. Then, when quitting the app via ⌘Q, the settings are not saved.
Unlike @marcfusch, I was also logged out (spotify auth was not preserved). When force quitting via ⌘⌥⎋, settings are indeed saved.
Also unlike their situation, on my succeeding launches and "normal quits", preference changes are not saved (e.g. theme and album covers). I have to force quit for changes to persist, which is a little funny and counterintuitive.
Happy to provide any additional information if it helps.
@jacksongoode commented on GitHub (Apr 20, 2025):
I believe this will be fixed by #602
@future10se commented on GitHub (Apr 20, 2025):
Yes, I can confirm this fixes the problem for me. Thank you for your work on Psst! <3