mirror of
https://github.com/jpochyla/psst.git
synced 2026-04-27 15:35:56 +03:00
[GH-ISSUE #515] User/pass auth flow now unsupported (Spotify API change) #315
Labels
No labels
api
bug
build
documentation
duplicate
enhancement
good first issue
help wanted
idea
invalid
linux
lowprio
macos
pull-request
upstream
windows
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/psst#315
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jacksongoode on GitHub (Aug 12, 2024).
Original GitHub issue: https://github.com/jpochyla/psst/issues/515
Describe the bug
https://github.com/librespot-org/librespot/issues/1308
Spotify just recently made this change within the last couple days. It breaks all 3rd party apps with this login method. This likely means we'll need to rework the authentication flow since we can't use username and passwords. This will need to be addressed immediately.
To Reproduce
Clear cache & sign in.
@ewancg commented on GitHub (Aug 12, 2024):
Is there a known alternative auth method?
@kingosticks commented on GitHub (Aug 12, 2024):
@jacksongoode regarding your comment in #1309, I am curious, given you've re-implemented much of librespot already here, why not do that for the oauth stuff too? There's not that much to it (even less if you take a simpler approach to the actual oauth bit and omit the superfluous
ExtraTokenFields). You might be waiting a while for it to be merged otherwise.@jacksongoode commented on GitHub (Aug 14, 2024):
Working on a PR to implement the login5 method.
@kingosticks commented on GitHub (Aug 14, 2024):
If you just want to fix this particular problem and get login working again, you don't need login5. You only really need to some oauth gubbins stuff to get an access token, then login with it using
AuthenticationType::AUTHENTICATION_SPOTIFY_TOKENto obtain reusable credentials, and then re-auth the session with those reusable credentials.I mixed Login5 support into my PR because we previously had problems obtaining additional tokens (via tokenmaster) with a
AUTHENTICATION_SPOTIFY_TOKEN-authed session but it seems Spotify have fixed that. I think I will remove all the Login5 stuff from my PR since it belong in a separate PR. Thanks for making me realise!@arch-btw commented on GitHub (Sep 3, 2024):
Thank you @jacksongoode