mirror of
https://github.com/jpochyla/psst.git
synced 2026-04-27 15:35:56 +03:00
[GH-ISSUE #476] New layout proposition. #300
Labels
No labels
api
bug
build
documentation
duplicate
enhancement
good first issue
help wanted
idea
invalid
linux
lowprio
macos
pull-request
upstream
windows
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/psst#300
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @SO9010 on GitHub (May 21, 2024).
Original GitHub issue: https://github.com/jpochyla/psst/issues/476
Is your feature request related to a problem? Please describe.
The layout isn't great and it could be improved.
Describe the solution you'd like
I think that a new side bar could be added which contains the playback queue. There would be three sections here:
One main section with the curently playing song with the album cover and the information with it, this could partially replace the currently playing section in the currernt design.
One section for the user added queue.
One section for the queue that will be played from the playlist.
I think that the proportions could be inproved. the play back bar isn't in-line with the bar on the right. Same with the top.
I think that the volume bar can be moved to the right of the playback options. To replace where it originally was we can put the search bar.
Then I think that there coud be a playlist pinning option where the search bar used to be.
Additionally, optionally I think that there could be a search icon at the top right of the playlist to search the playlist.
I think the muted mic icon is a bit pointless and should be replaced by the Psst icon.
Please refer to my mock-up for an example
Describe alternatives you've considered
Yes, the search icon in the top right is not nessisary.
I am happy to work on this in my free time, I just want to make sure that my idea alligns in a similar way to all of yours!
Additional context
@jacksongoode commented on GitHub (Jun 15, 2024):
I definitely have been thinking about how we ought to display the queue now that functionality is provided.
@SO9010 commented on GitHub (Jun 16, 2024):
Perhaps just a collapsible scroll view on the right (much like shown) could be used where it is automatically shown when the window is over a certain size, and if not it can be temporarily shown using a button?
@jacksongoode commented on GitHub (Jun 16, 2024):
That seems good, I would also think that we should lock the width of the left and right sidebars. Currently, Spotify's desktop is a mess with how it has to handle resizing. It seems like a headache to try to handle all the cases. We can just deal with the reflow of the center and disable the right sidebar if its too small of a window size maybe?
@SO9010 commented on GitHub (Jun 16, 2024):
Yes that seems good, I was wandering about the functionality, should it be an interactive thing where you can say skip to a certain part of the queue or where you can remove something from the queue? I feel like rearranging would be too much effort for small results.
@jacksongoode commented on GitHub (Jun 18, 2024):
Hmm yeah I suppose to add a queue view we should have "Remove from queue" methods for the items within the queue. We would need to refresh that queue view when an add or remove happens so we have an updated view of the queue. I don't think the methods would be hard but the refresh might be.
@SO9010 commented on GitHub (Jun 27, 2024):
Heya I have been programming a bit, I wanted your input. This is how it looks currently:
https://github.com/jpochyla/psst/assets/77629938/cfe4e8d0-b5ff-458c-8a81-e8aac817ef20
What do you think about that? is the styling O.K, or does it not fit in enough?
@jacksongoode commented on GitHub (Jun 28, 2024):
Really beautiful stuff!
Generally I was thinking that the right side bar would mimic the existing styling for of the
list_widgetthat we have with a bordered divider that exists on the left side - like in your previous prototype. I think that might be easy, but I think we should definitely not have the album art attached to each item in the list.I like having the "Queue" title match the header bar height of the center header. It might even be nice to have the number of queued tracks in parentheses "Queue (22)". However, space could be saved if we removed it too. Both are options.
I'm not sure about the text alignment being centered. I think it should either keep with the left text alignment with the center view, it would also make the style more consistent.
@SO9010 What do you think about these ideas?
@SO9010 commented on GitHub (Jun 28, 2024):
Thank you!
I agree with keeping the styling consistent with the left sidebar.
The reason for centering the text was because I was considering programming a system that loops the text. This would also be implemented when a song name is too long in the main playlist view. Should I do that? May take me a while!
I think just keeping the title as "Queue" would make it cleaner. Perhaps we could display the length of the queue in a darker font on the side, so it's not too intrusive.
Regarding the removal of the top icon, I believe something should be there for the alignment of the other top bars. Without it, the interface looks a bit unfriendly / disorganized. Perhaps then the main logo could go there.
I also need to fix the left bar to maintain a consistent size.
Additionally, I was wondering if it's a good idea to have two separate queue views: one for the user-added queue and one for the queue that comes from the playlist. This way, the user can see the difference when they change the play mode, such as switching to shuffle mode.
What do you think?
@jacksongoode commented on GitHub (Jun 28, 2024):
Okay that could be nice! Maybe some buttons could live there as well, like a "Clear queue" icon button.
Hmm, I'm not confident if it makes sense to put something there... This would be a separate discussion but at least on macOS that space is partially occupied by the windows controls which makes it look less unaligned.
I think a square icon would be a little awkward but definitely open to some ideas!
That seems good.
This seems really nice and would take care of the annoying graphical issues with titles and albums that are too long.
However, I do think we should hold off on that as a separate feature. I think maybe a first PR would just be adding the queue widget in the same style as the general
list_widget(without album art). I think the playlist context "queue" shouldn't really be associated with the user defined queue - just thinking it would really complicate the navigational flow of the two views. It would be nice to at least get some truncation for these current long titles though, so the "like" button doesn't overlap.@jacksongoode commented on GitHub (Jun 29, 2024):
@SO9010 Are you working on a branch? You could open as a draft PR and I'd be happy to work on it with you if you'd like?
@SO9010 commented on GitHub (Jun 29, 2024):
Yes, that sounds perfect. I will do that tomorrow. Also, I have ensured that it follows the theming you wanted. I will be away for the next week or so, so I won't be able to program during that time.
Just as a heads-up, my code isn't in the best shape right now. I'm currently creating a rough draft of how I think the code should work, and I plan to go back and optimize it later. Please feel free to be very critical of my code.