mirror of
https://github.com/jpochyla/psst.git
synced 2026-04-27 15:35:56 +03:00
[GH-ISSUE #456] Search inside playlist #283
Labels
No labels
api
bug
build
documentation
duplicate
enhancement
good first issue
help wanted
idea
invalid
linux
lowprio
macos
pull-request
upstream
windows
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/psst#283
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @CypherPotato on GitHub (Feb 16, 2024).
Original GitHub issue: https://github.com/jpochyla/psst/issues/456
Is your feature request related to a problem? Please describe.
There should be a way to search for a song or artist within the playlist or saved songs
Describe the solution you'd like
A separate search bar, or button that opens the search bar, that when searching, filters the results based on what I searched for. When playing a song from these results, play only the filtered part of the playlist.
Describe alternatives you've considered
There is no other way to do this.
Additional context
I'm talking about this button.
@jacksongoode commented on GitHub (Feb 18, 2024):
Ohh that's a good idea! Shouldn't be too hard I don't think.
@jacksongoode commented on GitHub (Jun 20, 2024):
Does Cmd/Ctrl+F within the playlist work for you @CypherPotato ?
@CypherPotato commented on GitHub (Jun 22, 2024):
@jacksongoode hello. I've tried it in the version from commit #
913dae1but couldn't get it working.@jacksongoode commented on GitHub (Jul 10, 2024):
@CypherPotato Which platform are you on? The search should really filter the list completely. Right now it just highlights the items that match.
That seems like a separate context based kind of situation that would be a little tricky to figure out.
@SO9010 commented on GitHub (Aug 24, 2024):
This is addressed in #511; I also found that Cmd/Ctrl+F doesn't work on my devices. The playing from only the filtered part of the playlist doesn't make much sense and could be a very niche use case. However, with the current search filter, it should, as @jacksongoode says, either filter the list by removing the other songs in the playlist or, in my opinion, a far more effective way of doing it would be having an auto-scroll to position a bit like when in VSCode. I am happy to work on this as well.