mirror of
https://github.com/jpochyla/psst.git
synced 2026-04-27 23:45:57 +03:00
[GH-ISSUE #350] MacOS Native Media Player playback bar out-of-sync #240
Labels
No labels
api
bug
build
documentation
duplicate
enhancement
good first issue
help wanted
idea
invalid
linux
lowprio
macos
pull-request
upstream
windows
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/psst#240
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @royathan on GitHub (Oct 20, 2022).
Original GitHub issue: https://github.com/jpochyla/psst/issues/350
Describe the bug
On MacOS the native media player playback bar is not controllable and does not follow along with the same bar in the Psst application.
To Reproduce
Play any song via Psst on MacOS, then try to change to a different part of the song via the native MacOS media player.
As well, you can change the position in the song via Psst, and watch the progress not get reflected in the native media player.
Expected behavior
The native MacOS media player playback progress bar should allow you to control the position in the song.
Screenshots


Environment
Additional context
The souvlaki
MediaControlEvent::SetPositionevent hasn't been implemented yet in Psst, as well, the MacOS implementation in souvlaki itself isn't completed. As well, theupdate_media_control_metadata()method is only being called during play/pause and needs to have some of its code pulled out and used during acmd::PLAY_SEEKevent.@royathan commented on GitHub (Oct 20, 2022):
I'm working on this now. I've opened a PR to implement the SetPosition event for MacOS in souvlaki. Once that is handled I can open a PR with the rest of the changes listed in the Additional Context. Though depending on how long the souvlaki PR takes to get wrapped up I may work on the metadata updating as a separate branch.
@Insprill commented on GitHub (Jan 12, 2023):
Closed with #351 and #352.