[GH-ISSUE #319] Latest commit (9128669...) doesn't compile #228

New issue

Closed

opened 2026-02-28 14:31:30 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:31:30 +03:00

Owner

Originally created by @riskable on GitHub (Aug 4, 2022).
Original GitHub issue: https://github.com/jpochyla/psst/issues/319

Describe the bug
Doing a fresh git pull (or clone) and cargo clean followed by cargo build --release results in compilation errors (see below). This is true for both stable and nightly.

To Reproduce
git clone <the repo>; cargo update; cargo build --release

Expected behavior
I expect it to actually build successfully 😄

Screenshots

Environment

OS: Kubuntu Linux
Version: 22.04

Tested with stable-x86_64-unknown-linux-gnu and nightly-x86_64-unknown-linux-gnu (as of 20220804)

Additional context
Here's the full (textual) terminal output (so you don't have to reference that screenshot):

psst on  master [$!?] via 🦀 v1.62.1 
❯ cargo build --release
warning: unused imports: `Receiver`, `Sender`
 --> psst-core/src/audio/output/mod.rs:2:25
  |
2 | use crossbeam_channel::{Receiver, Sender};
  |                         ^^^^^^^^  ^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

warning: field is never read: `result`
  --> psst-core/src/cdn.rs:52:13
   |
52 |             result: String,
   |             ^^^^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

warning: field is never read: `fileid`
  --> psst-core/src/cdn.rs:54:13
   |
54 |             fileid: String,
   |             ^^^^^^^^^^^^^^

warning: `psst-core` (lib) generated 3 warnings
   Compiling psst-cli v0.1.0 (/storage/downloads/psst/psst-cli)
   Compiling gdk-pixbuf v0.14.0
warning: trait objects without an explicit `dyn` are deprecated
  --> psst-cli/src/main.rs:53:18
   |
53 |     let output = AudioOutput::open()?;
   |                  ^^^^^^^^^^^
   |
   = note: `#[warn(bare_trait_objects)]` on by default
   = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
   = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/warnings-promoted-to-error.html>
help: use `dyn`
   |
53 |     let output = <dyn AudioOutput>::open()?;
   |                  ++++            +

error[E0191]: the value of the associated type `Sink` (from trait `AudioOutput`) must be specified
  --> psst-cli/src/main.rs:53:18
   |
53 |     let output = AudioOutput::open()?;
   |                  ^^^^^^^^^^^ help: specify the associated type: `AudioOutput<Sink = Type>`

error[E0599]: no function or associated item named `open` found for trait object `dyn AudioOutput` in the current scope
  --> psst-cli/src/main.rs:53:31
   |
53 |     let output = AudioOutput::open()?;
   |                               ^^^^ function or associated item not found in `dyn AudioOutput`

error[E0599]: no method named `close` found for struct `CpalSink` in the current scope
   --> psst-cli/src/main.rs:105:19
    |
105 |     output.sink().close();
    |                   ^^^^^ method not found in `CpalSink`
    |
   ::: /storage/downloads/psst/psst-core/src/audio/output/mod.rs:30:8
    |
30  |     fn close(&self);
    |        ----- the method is available for `CpalSink` here
    |
    = help: items from traits can only be used if the trait is in scope
help: the following trait is implemented but not in scope; perhaps add a `use` for it:
    |
1   | use psst_core::audio::output::AudioSink;
    |

Some errors have detailed explanations: E0191, E0599.
For more information about an error, try `rustc --explain E0191`.
warning: `psst-cli` (bin "psst-cli") generated 1 warning
error: could not compile `psst-cli` due to 3 previous errors; 1 warning emitted
warning: build failed, waiting for other jobs to finish...

I don't know which commit did it but the last time I tried to build psst was a little over two weeks ago. So it broke some time between then and now.

Originally created by @riskable on GitHub (Aug 4, 2022). Original GitHub issue: https://github.com/jpochyla/psst/issues/319 **Describe the bug** Doing a fresh `git pull` (or clone) and `cargo clean` followed by `cargo build --release` results in compilation errors (see below). This is true for both stable and nightly. **To Reproduce** `git clone <the repo>; cargo update; cargo build --release` **Expected behavior** I expect it to actually build successfully :smile: **Screenshots** ![Screenshot_20220804_110218](https://user-images.githubusercontent.com/66987/182880861-f41867ef-602f-450d-8b74-59e85ea38f7b.png) **Environment** - OS: Kubuntu Linux - Version: 22.04 Tested with `stable-x86_64-unknown-linux-gnu` and `nightly-x86_64-unknown-linux-gnu` (as of 20220804) **Additional context** Here's the full (textual) terminal output (so you don't have to reference that screenshot): ```bash psst on  master [$!?] via 🦀 v1.62.1 ❯ cargo build --release warning: unused imports: `Receiver`, `Sender` --> psst-core/src/audio/output/mod.rs:2:25 | 2 | use crossbeam_channel::{Receiver, Sender}; | ^^^^^^^^ ^^^^^^ | = note: `#[warn(unused_imports)]` on by default warning: field is never read: `result` --> psst-core/src/cdn.rs:52:13 | 52 | result: String, | ^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default warning: field is never read: `fileid` --> psst-core/src/cdn.rs:54:13 | 54 | fileid: String, | ^^^^^^^^^^^^^^ warning: `psst-core` (lib) generated 3 warnings Compiling psst-cli v0.1.0 (/storage/downloads/psst/psst-cli) Compiling gdk-pixbuf v0.14.0 warning: trait objects without an explicit `dyn` are deprecated --> psst-cli/src/main.rs:53:18 | 53 | let output = AudioOutput::open()?; | ^^^^^^^^^^^ | = note: `#[warn(bare_trait_objects)]` on by default = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/warnings-promoted-to-error.html> help: use `dyn` | 53 | let output = <dyn AudioOutput>::open()?; | ++++ + error[E0191]: the value of the associated type `Sink` (from trait `AudioOutput`) must be specified --> psst-cli/src/main.rs:53:18 | 53 | let output = AudioOutput::open()?; | ^^^^^^^^^^^ help: specify the associated type: `AudioOutput<Sink = Type>` error[E0599]: no function or associated item named `open` found for trait object `dyn AudioOutput` in the current scope --> psst-cli/src/main.rs:53:31 | 53 | let output = AudioOutput::open()?; | ^^^^ function or associated item not found in `dyn AudioOutput` error[E0599]: no method named `close` found for struct `CpalSink` in the current scope --> psst-cli/src/main.rs:105:19 | 105 | output.sink().close(); | ^^^^^ method not found in `CpalSink` | ::: /storage/downloads/psst/psst-core/src/audio/output/mod.rs:30:8 | 30 | fn close(&self); | ----- the method is available for `CpalSink` here | = help: items from traits can only be used if the trait is in scope help: the following trait is implemented but not in scope; perhaps add a `use` for it: | 1 | use psst_core::audio::output::AudioSink; | Some errors have detailed explanations: E0191, E0599. For more information about an error, try `rustc --explain E0191`. warning: `psst-cli` (bin "psst-cli") generated 1 warning error: could not compile `psst-cli` due to 3 previous errors; 1 warning emitted warning: build failed, waiting for other jobs to finish... ``` I don't know which commit did it but the last time I tried to build psst was a little over two weeks ago. So it broke some time between then and now.