mirror of
https://github.com/jpochyla/psst.git
synced 2026-04-27 07:25:52 +03:00
[GH-ISSUE #259] Build fail: "Could not compile resource file" - Windows 10 #189
Labels
No labels
api
bug
build
documentation
duplicate
enhancement
good first issue
help wanted
idea
invalid
linux
lowprio
macos
pull-request
upstream
windows
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/psst#189
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @geom3trik on GitHub (Jan 14, 2022).
Original GitHub issue: https://github.com/jpochyla/psst/issues/259
Describe the bug
The application failed to build on my Windows 10 machine with the following error:
To Reproduce
Ran the following commands in the
psst-guidirectory:Expected behavior
Build success.
Screenshots
N/A
Environment
Additional context
My default cargo toolchain is stable-gnu but I also tried stable-msvc and nightly-gnu.
@jpochyla commented on GitHub (Jan 25, 2022):
Do you know why the GH Action succeeds but the process fails on your machine?
@geom3trik commented on GitHub (Jan 26, 2022):
I'm sorry I do not. I'm guessing that maybe I might be missing some library perhaps? Do you know if anything special is required for "attaching the icon" or "compiling the resource file"? I'll be honest I'm not entirely sure I understand what the error is saying, but looking at the code and at the files I can't find an icon file so I assume it's supposed to be generated or something?
@CSymes commented on GitHub (Feb 8, 2022):
Just had a quick look, it's because the psst-gui/assets/logo.ico file is missing. Peeking at the build pipeline, it is indeed getting generated at build-time, and creating that file locally allows me to build and run it (although it doesn't actually display on the application when running
cargo run, but that's presumably another issue).Seeing as the repo already includes many other raster icons, is there any reason not to just include
logo.icoadditionally?Alternately, could generate it during the build (obviously this would add a dependency on imagemagick), or at the minimum, perhaps yield a more useful error indicating that the file needs to be generated prior to build.