mirror of
https://github.com/jpochyla/psst.git
synced 2026-04-27 23:45:57 +03:00
[GH-ISSUE #13] Add UI for incorrect credentials? #11
Labels
No labels
api
bug
build
documentation
duplicate
enhancement
good first issue
help wanted
idea
invalid
linux
lowprio
macos
pull-request
upstream
windows
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/psst#11
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jasikpark on GitHub (Jan 4, 2021).
Original GitHub issue: https://github.com/jpochyla/psst/issues/13
Currently there is logging for incorrect credentials, but there is no way to see in the interface that the credentials have been saved, updated, are incorrect, or are already saved and won't be replaced since they are the same.
@jasikpark commented on GitHub (Jan 4, 2021):
I keep getting "already configured" when trying to update my credentials
@jasikpark commented on GitHub (Jan 4, 2021):
Hmmmm ok so the logging is just simply not very clear, rather than the application being wrong, since I tried to clear my credentials and save and when I checked the config.json in application support, the credentials were cleared.
@jpochyla commented on GitHub (Jan 5, 2021):
So I think the strategy here would be to try to connect in the config dialog itself, and show the error there. What is problematic in the current codebase is "restarting" already running session with different credentials, and that's what these "already configured" errors mean. It should work if you restart the app, although I agree it's not ideal.
@OpenUAS commented on GitHub (Jan 7, 2021):
+1 for this change welcomed. The good thing is, pssst compiles and runs well on Ubuntu 20.04, now only if I would have a Spotify account ;) Tried it since this is good example for a rust app with Druid GUI.
@brightly-salty commented on GitHub (Mar 7, 2021):
I think it would also be useful to include a string representation of the error.
AuthFailed { 11 }is the error I got, but it took digging through keyexchange.proto to find that this meant "Premium account required".@jpochyla commented on GitHub (Mar 13, 2021):
Credential dialog is a bit nicer now, closing. Feel free to open issues in case of any problems!