[GH-ISSUE #13] Add UI for incorrect credentials? #11

Closed
opened 2026-02-28 14:29:56 +03:00 by kerem · 6 comments
Owner

Originally created by @jasikpark on GitHub (Jan 4, 2021).
Original GitHub issue: https://github.com/jpochyla/psst/issues/13

Currently there is logging for incorrect credentials, but there is no way to see in the interface that the credentials have been saved, updated, are incorrect, or are already saved and won't be replaced since they are the same.

Screen Shot 2021-01-04 at 5 02 40 PM
Originally created by @jasikpark on GitHub (Jan 4, 2021). Original GitHub issue: https://github.com/jpochyla/psst/issues/13 Currently there is logging for incorrect credentials, but there is no way to see in the interface that the credentials have been saved, updated, are incorrect, or are already saved and won't be replaced since they are the same. <img width="1792" alt="Screen Shot 2021-01-04 at 5 02 40 PM" src="https://user-images.githubusercontent.com/10626596/103588483-e5b43280-4eae-11eb-841d-74105dae0e26.png">
kerem closed this issue 2026-02-28 14:29:56 +03:00
Author
Owner

@jasikpark commented on GitHub (Jan 4, 2021):

I keep getting "already configured" when trying to update my credentials

<!-- gh-comment-id:754275818 --> @jasikpark commented on GitHub (Jan 4, 2021): I keep getting "already configured" when trying to update my credentials
Author
Owner

@jasikpark commented on GitHub (Jan 4, 2021):

Hmmmm ok so the logging is just simply not very clear, rather than the application being wrong, since I tried to clear my credentials and save and when I checked the config.json in application support, the credentials were cleared.

<!-- gh-comment-id:754276500 --> @jasikpark commented on GitHub (Jan 4, 2021): Hmmmm ok so the logging is just simply not very clear, rather than the application being wrong, since I tried to clear my credentials and save and when I checked the config.json in application support, the credentials were cleared.
Author
Owner

@jpochyla commented on GitHub (Jan 5, 2021):

So I think the strategy here would be to try to connect in the config dialog itself, and show the error there. What is problematic in the current codebase is "restarting" already running session with different credentials, and that's what these "already configured" errors mean. It should work if you restart the app, although I agree it's not ideal.

<!-- gh-comment-id:754563352 --> @jpochyla commented on GitHub (Jan 5, 2021): So I think the strategy here would be to try to connect in the config dialog itself, and show the error there. What is problematic in the current codebase is "restarting" already running session with different credentials, and that's what these "already configured" errors mean. It should work if you restart the app, although I agree it's not ideal.
Author
Owner

@OpenUAS commented on GitHub (Jan 7, 2021):

+1 for this change welcomed. The good thing is, pssst compiles and runs well on Ubuntu 20.04, now only if I would have a Spotify account ;) Tried it since this is good example for a rust app with Druid GUI.

<!-- gh-comment-id:756243279 --> @OpenUAS commented on GitHub (Jan 7, 2021): +1 for this change welcomed. The good thing is, pssst compiles and runs well on Ubuntu 20.04, now only if I would have a Spotify account ;) Tried it since this is good example for a rust app with Druid GUI.
Author
Owner

@brightly-salty commented on GitHub (Mar 7, 2021):

I think it would also be useful to include a string representation of the error. AuthFailed { 11 } is the error I got, but it took digging through keyexchange.proto to find that this meant "Premium account required".

<!-- gh-comment-id:792310987 --> @brightly-salty commented on GitHub (Mar 7, 2021): I think it would also be useful to include a string representation of the error. `AuthFailed { 11 }` is the error I got, but it took digging through keyexchange.proto to find that this meant "Premium account required".
Author
Owner

@jpochyla commented on GitHub (Mar 13, 2021):

Credential dialog is a bit nicer now, closing. Feel free to open issues in case of any problems!

<!-- gh-comment-id:798617735 --> @jpochyla commented on GitHub (Mar 13, 2021): Credential dialog is a bit nicer now, closing. Feel free to open issues in case of any problems!
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/psst#11
No description provided.