mirror of
https://github.com/ProxymanApp/proxyman-windows-linux.git
synced 2026-04-27 08:55:50 +03:00
[GH-ISSUE #4] Window Management button #6
Labels
No labels
Linux
bug
enhancement
enhancement
pull-request
question
✅ Done
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/proxyman-windows-linux#6
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @NghiaTranUIT on GitHub (Jun 29, 2022).
Original GitHub issue: https://github.com/ProxymanApp/proxyman-windows-linux/issues/4
Originally assigned to: @kics223w1 on GitHub.
Description
We should implement the logic for 3 window management buttons
Acceptance Criteria
@kics223w1 commented on GitHub (Aug 11, 2022):
After an evening of finding the solution for the last bug, I end up with nothing.
The bug is when
SplitPanechanges fromverticaltohorizontalor vice versa all rows in DataGrid will disappear. I have no idea why that happens. This issue Mui DataGrid rows disappear seems like a good solution but it still does not work.There is a not good solution is: We add rows again after changing the style
SplitPane.So please feel free to take over this ticket, you can use my code to reference. My code is done 90% if that bug is solved this ticket will be done.
I will continue with ticket export.
Video Bug
https://user-images.githubusercontent.com/77295189/184125585-529062e5-39d6-4041-85cc-7459f03f964c.mp4
@NghiaTranUIT commented on GitHub (Aug 12, 2022):
The SplitPanel is super buggy IMO. It's not designed for ReactJS 18.
@kics223w1 let's try migrating to SplitJS: https://split.js.org/
Ref: https://github.com/ProxymanApp/proxyman-electron-app/pull/45
@kics223w1 commented on GitHub (Aug 12, 2022):
Yes I got it.
@NghiaTranUIT commented on GitHub (Nov 25, 2022):
Since we support the Source List Panel. We can revisit this ticket to make it works with all panels (Left, Middle, Right/Bottom).
Move this ticket to 0.10.0 version 👍