[GH-ISSUE #4] Window Management button #6

Open
opened 2026-03-03 19:48:13 +03:00 by kerem · 4 comments
Owner

Originally created by @NghiaTranUIT on GitHub (Jun 29, 2022).
Original GitHub issue: https://github.com/ProxymanApp/proxyman-windows-linux/issues/4

Originally assigned to: @kics223w1 on GitHub.

Description

We should implement the logic for 3 window management buttons

Screen_Shot_2022-06-29_at_15_30_10

Acceptance Criteria

  • The left button: Toggle the Left Panel
  • The right button: Toggle the right panel
  • The middle button: Toggle the Bottom panel
  • All three buttons state are persisted after closing the app
  • When open Proxyman, Proxyman will restore to previous states
Originally created by @NghiaTranUIT on GitHub (Jun 29, 2022). Original GitHub issue: https://github.com/ProxymanApp/proxyman-windows-linux/issues/4 Originally assigned to: @kics223w1 on GitHub. ## Description We should implement the logic for 3 window management buttons ![Screen_Shot_2022-06-29_at_15_30_10](https://user-images.githubusercontent.com/5878421/176390404-b818d54a-2305-425c-9599-ef9078c61bac.jpg) ## Acceptance Criteria - The left button: Toggle the Left Panel - The right button: Toggle the right panel - The middle button: Toggle the Bottom panel - All three buttons state are persisted after closing the app - When open Proxyman, Proxyman will restore to previous states
Author
Owner

@kics223w1 commented on GitHub (Aug 11, 2022):

After an evening of finding the solution for the last bug, I end up with nothing.

The bug is when SplitPane changes from vertical to horizontal or vice versa all rows in DataGrid will disappear. I have no idea why that happens. This issue Mui DataGrid rows disappear seems like a good solution but it still does not work.
There is a not good solution is: We add rows again after changing the style SplitPane.

So please feel free to take over this ticket, you can use my code to reference. My code is done 90% if that bug is solved this ticket will be done.
I will continue with ticket export.

Video Bug
https://user-images.githubusercontent.com/77295189/184125585-529062e5-39d6-4041-85cc-7459f03f964c.mp4

<!-- gh-comment-id:1211875997 --> @kics223w1 commented on GitHub (Aug 11, 2022): After an evening of finding the solution for the last bug, I end up with nothing. The bug is when `SplitPane` changes from `vertical` to `horizontal` or vice versa all rows in DataGrid will disappear. I have no idea why that happens. This [issue Mui DataGrid rows disappear](https://github.com/mui/mui-x/issues/1908) seems like a good solution but it still does not work. There is a not good solution is: We add rows again after changing the style `SplitPane`. So please feel free to take over this ticket, you can use [my code](https://github.com/ProxymanApp/proxyman-electron-app/compare/feat/management-button?expand=1) to reference. My code is done 90% if that bug is solved this ticket will be done. I will continue with [ticket export](https://github.com/ProxymanApp/proxyman-windows-linux/issues/36). Video Bug https://user-images.githubusercontent.com/77295189/184125585-529062e5-39d6-4041-85cc-7459f03f964c.mp4
Author
Owner

@NghiaTranUIT commented on GitHub (Aug 12, 2022):

The SplitPanel is super buggy IMO. It's not designed for ReactJS 18.

@kics223w1 let's try migrating to SplitJS: https://split.js.org/

Ref: https://github.com/ProxymanApp/proxyman-electron-app/pull/45

<!-- gh-comment-id:1212643394 --> @NghiaTranUIT commented on GitHub (Aug 12, 2022): The SplitPanel is super buggy IMO. It's not designed for ReactJS 18. @kics223w1 let's try migrating to SplitJS: https://split.js.org/ Ref: https://github.com/ProxymanApp/proxyman-electron-app/pull/45
Author
Owner

@kics223w1 commented on GitHub (Aug 12, 2022):

Yes I got it.

<!-- gh-comment-id:1212654514 --> @kics223w1 commented on GitHub (Aug 12, 2022): Yes I got it.
Author
Owner

@NghiaTranUIT commented on GitHub (Nov 25, 2022):

Since we support the Source List Panel. We can revisit this ticket to make it works with all panels (Left, Middle, Right/Bottom).

Move this ticket to 0.10.0 version 👍

<!-- gh-comment-id:1326937294 --> @NghiaTranUIT commented on GitHub (Nov 25, 2022): Since we support the Source List Panel. We can revisit this ticket to make it works with all panels (Left, Middle, Right/Bottom). Move this ticket to 0.10.0 version 👍
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/proxyman-windows-linux#6
No description provided.