mirror of
https://github.com/proxmoxer/proxmoxer.git
synced 2026-04-25 23:26:00 +03:00
[GH-ISSUE #107] Make default port configurable #57
Labels
No labels
backend:https
backend:local
backend:openssh
backend:ssh_paramiko
pull-request
status:ansible-issue
status:help-wanted
status:info-needed
status:proxmox-issue
status:review-needed
type:bug 🐞
type:dependency ⛓️
type:docs 📝
type:enhancement ⏫
type:maintenance 🛠️
type:meta
type:question ❓
type:request ✋
type:testing 🧪
version:1.x
version:latest
version:py2
version:py3
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/proxmoxer#57
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @fernwerker on GitHub (Aug 3, 2022).
Original GitHub issue: https://github.com/proxmoxer/proxmoxer/issues/107
Originally assigned to: @jhollowe on GitHub.
Hi,
I think this value should not be hard-coded but made configurable (e.g. by host:port) value to make use of API behind reverse proxy that offers tcp/443 UI and not tcp/8006
github.com/proxmoxer/proxmoxer@7a49519883/proxmoxer/core.py (L42)Relates to: https://github.com/prometheus-pve/prometheus-pve-exporter/issues/117
@jhollowe commented on GitHub (Aug 4, 2022):
by definition, a default port must be hard-coded so there can be a default.
But you can pass a port into proxmoxer using either the
portargument or just adding:<port>to the hostname.The port is extracted from the host and only if it is missing is the default port for that service used.
github.com/proxmoxer/proxmoxer@23614c8693/proxmoxer/backends/https.py (L277)