[PR #163] [MERGED] Fix improper spliting of non-exec QEMU commands #196

New issue

Closed

opened 2026-02-27 15:46:52 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:46:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/proxmoxer/proxmoxer/pull/163
Author: @jhollowe
Created: 4/4/2024
Status: ✅ Merged
Merged: 4/12/2024
Merged by: @jhollowe

Base: develop ← Head: bugfix/qemu-split

📝 Commits (2)

0e820fb Fix improper spliting of non-exec QEMU commands
76a9590 Remove unneeded section in test mock

📊 Changes

3 files changed (+78 additions, -7 deletions)

View changed files

📝 proxmoxer/backends/https.py (+1 -1)
📝 tests/api_mock.py (+45 -0)
📝 tests/test_https.py (+32 -6)

📄 Description

Only split a string into an array for the /qemu/{vmid}/agent/exec endpoint. Spliting other command key/value pairs breaks other QEMU endpoints e.g. /qemu/{vmid}/monitor

Fixes: #161

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/proxmoxer/proxmoxer/pull/163 **Author:** [@jhollowe](https://github.com/jhollowe) **Created:** 4/4/2024 **Status:** ✅ Merged **Merged:** 4/12/2024 **Merged by:** [@jhollowe](https://github.com/jhollowe) **Base:** `develop` ← **Head:** `bugfix/qemu-split` --- ### 📝 Commits (2) - [`0e820fb`](https://github.com/proxmoxer/proxmoxer/commit/0e820fbf8be62652ce50d6954eb50edc5c7f0a33) Fix improper spliting of non-exec QEMU commands - [`76a9590`](https://github.com/proxmoxer/proxmoxer/commit/76a9590ca7c81d419d09ba3aa1fc33077781a918) Remove unneeded section in test mock ### 📊 Changes **3 files changed** (+78 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `proxmoxer/backends/https.py` (+1 -1) 📝 `tests/api_mock.py` (+45 -0) 📝 `tests/test_https.py` (+32 -6) </details> ### 📄 Description Only split a string into an array for the [`/qemu/{vmid}/agent/exec` endpoint](https://pve.proxmox.com/pve-docs/api-viewer/index.html#/nodes/{node}/qemu/{vmid}/agent/exec). Spliting other `command` key/value pairs breaks other QEMU endpoints e.g. [`/qemu/{vmid}/monitor`](https://pve.proxmox.com/pve-docs/api-viewer/index.html#/nodes/{node}/qemu/{vmid}/monitor) Fixes: #161 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 15:46:52 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/proxmoxer#196

No description provided.

Rows
Columns