[PR #141] [MERGED] remove Python <3.6 from setup.py #192

New issue

Closed

opened 2026-02-27 15:46:50 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:46:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/proxmoxer/proxmoxer/pull/141
Author: @russoz
Created: 7/6/2023
Status: ✅ Merged
Merged: 7/8/2023
Merged by: @jhollowe

Base: develop ← Head: setup-min-py36

📝 Commits (2)

30e1aea remove Python <3.6 from setup.py
4076723 Update setup.py

📊 Changes

1 file changed (+0 additions, -5 deletions)

View changed files

📝 setup.py (+0 -5)

📄 Description

Hi, I am a maintainer of Ansible's community.general collection (https://github.com/ansible-collections/community.general/) and I have been giving some love to the proxmox modules in the last couple of days. In doing so, I started looking into the code of proxmoxer, and I noticed that, despite using f-strings, setup.py still claims it is compatible with Python 2.7.

Hence, I am submitting this PR to set the minimum version at Python 3.6 when f-strings were introduced. I have not examined the code further to determine if other dependencies to higher versions of Python are in use. It might be good to check on that though.

Thanks
Alex

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/proxmoxer/proxmoxer/pull/141 **Author:** [@russoz](https://github.com/russoz) **Created:** 7/6/2023 **Status:** ✅ Merged **Merged:** 7/8/2023 **Merged by:** [@jhollowe](https://github.com/jhollowe) **Base:** `develop` ← **Head:** `setup-min-py36` --- ### 📝 Commits (2) - [`30e1aea`](https://github.com/proxmoxer/proxmoxer/commit/30e1aeaed03708d88f6798da6437ef4cc9ca769d) remove Python <3.6 from setup.py - [`4076723`](https://github.com/proxmoxer/proxmoxer/commit/4076723add3d498e08acf525896b8e6bba7e2de6) Update setup.py ### 📊 Changes **1 file changed** (+0 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `setup.py` (+0 -5) </details> ### 📄 Description Hi, I am a maintainer of Ansible's community.general collection (https://github.com/ansible-collections/community.general/) and I have been giving some love to the proxmox modules in the last couple of days. In doing so, I started looking into the code of proxmoxer, and I noticed that, despite using f-strings, `setup.py` still claims it is compatible with Python 2.7. Hence, I am submitting this PR to set the minimum version at Python 3.6 when f-strings were introduced. I have not examined the code further to determine if other dependencies to higher versions of Python are in use. It might be good to check on that though. Thanks Alex --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 15:46:50 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/proxmoxer#192

No description provided.

Rows
Columns