[PR #121] [CLOSED] Fix resource method data integrity checks #181

New issue

Closed

opened 2026-02-27 15:46:48 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:46:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/proxmoxer/proxmoxer/pull/121
Author: @kristianheljas
Created: 11/19/2022
Status: ❌ Closed

Base: develop ← Head: resource-method-data-integrity

📝 Commits (1)

d8772cc Fix data integrity checks in TestProxmoxResource

📊 Changes

1 file changed (+19 additions, -15 deletions)

View changed files

📝 tests/test_core.py (+19 -15)

📄 Description

Although TestProxmoxResource did seem to check for data integrity, it did not.

Now the MockSession will return the request details instead of static value to check against.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/proxmoxer/proxmoxer/pull/121 **Author:** [@kristianheljas](https://github.com/kristianheljas) **Created:** 11/19/2022 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `resource-method-data-integrity` --- ### 📝 Commits (1) - [`d8772cc`](https://github.com/proxmoxer/proxmoxer/commit/d8772cc41d3b757d9f5fe6465fc0f0f5712d1f37) Fix data integrity checks in TestProxmoxResource ### 📊 Changes **1 file changed** (+19 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `tests/test_core.py` (+19 -15) </details> ### 📄 Description Although `TestProxmoxResource` did seem to check for data integrity, it did not. Now the `MockSession` will return the request details instead of static value to check against. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 15:46:48 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/proxmoxer#181

No description provided.

Rows
Columns