[PR #84] [MERGED] Add and apply formatting standards #166

New issue

Closed

opened 2026-02-27 15:46:45 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:46:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/proxmoxer/proxmoxer/pull/84
Author: @jhollowe
Created: 1/30/2022
Status: ✅ Merged
Merged: 1/30/2022
Merged by: @jhollowe

Base: develop ← Head: formatting-tooling

📝 Commits (10+)

d6d26a5 Add config for formatter and linter
3e41884 Add devcontainer/vscode config for formatting and linting
53e02e0 Add pre-commit hooks for formatting and linting
6cc2fec Add baseline for bandit
1622df9 Add environment linting pre-commit hooks
b1f26a2 Merge remote-tracking branch 'origin/develop' into formatting-tooling
9ce08d9 Add several pre-commit hooks and remove pylint
16c8263 Fix ordering of pre-commit hooks for docs
a8e6a0b Update pylint config
7a976de Format all code with pre-commit

📊 Changes

24 files changed (+1126 additions, -565 deletions)

View changed files

📝 .devcontainer/devcontainer.json (+1 -3)
➕ .git-blame-ignore-revs (+4 -0)
➕ .pre-commit-config.yaml (+60 -0)
📝 .vscode/settings.json (+18 -1)
📝 README.rst (+93 -56)
📝 dev_requirements.txt (+1 -0)
📝 proxmoxer/__init__.py (+5 -5)
📝 proxmoxer/backends/__init__.py (+3 -3)
📝 proxmoxer/backends/base_ssh.py (+27 -24)
📝 proxmoxer/backends/https.py (+143 -74)
📝 proxmoxer/backends/openssh.py (+47 -27)
📝 proxmoxer/backends/ssh_paramiko.py (+52 -31)
📝 proxmoxer/core.py (+51 -29)
➕ pyproject.toml (+3 -0)
➕ setup.cfg (+17 -0)
📝 setup.py (+25 -24)
📝 tests/__init__.py (+3 -4)
📝 tests/base/__init__.py (+3 -4)
📝 tests/base/base_ssh_suite.py (+85 -59)
📝 tests/https_helpers_tests.py (+47 -34)

...and 4 more files

📄 Description

Added configuration for formatting/linting
Added pre-commit tool and configured to run desired formatters/linters
Applied formatting/linting to all files
Created file to use with blame.ignorerevsfile git config to ignore the bulk-formatting commit from blame
Configured development environment to use formatting tooling

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/proxmoxer/proxmoxer/pull/84 **Author:** [@jhollowe](https://github.com/jhollowe) **Created:** 1/30/2022 **Status:** ✅ Merged **Merged:** 1/30/2022 **Merged by:** [@jhollowe](https://github.com/jhollowe) **Base:** `develop` ← **Head:** `formatting-tooling` --- ### 📝 Commits (10+) - [`d6d26a5`](https://github.com/proxmoxer/proxmoxer/commit/d6d26a54bf48ab514143b82bf2e825fc993150c1) Add config for formatter and linter - [`3e41884`](https://github.com/proxmoxer/proxmoxer/commit/3e418845e47ac46d3bcd422c0b8260ee538d4da8) Add devcontainer/vscode config for formatting and linting - [`53e02e0`](https://github.com/proxmoxer/proxmoxer/commit/53e02e0058f5e5cac8c5ed35870f18e47ed9d73a) Add pre-commit hooks for formatting and linting - [`6cc2fec`](https://github.com/proxmoxer/proxmoxer/commit/6cc2fec251d95bc0d2b2575f3e662cd7a934230f) Add baseline for bandit - [`1622df9`](https://github.com/proxmoxer/proxmoxer/commit/1622df9ae36e8751c84c6ff3272ba94845898924) Add environment linting pre-commit hooks - [`b1f26a2`](https://github.com/proxmoxer/proxmoxer/commit/b1f26a275fd577b0d22022efbc52b2424728763a) Merge remote-tracking branch 'origin/develop' into formatting-tooling - [`9ce08d9`](https://github.com/proxmoxer/proxmoxer/commit/9ce08d9e8084d4fd732e881edc6d1f49bfddb6e9) Add several pre-commit hooks and remove pylint - [`16c8263`](https://github.com/proxmoxer/proxmoxer/commit/16c8263a648acdb6037d82fce33bc7a5b4bf3612) Fix ordering of pre-commit hooks for docs - [`a8e6a0b`](https://github.com/proxmoxer/proxmoxer/commit/a8e6a0bd4cc8476684388bbb2df7e56e1042c705) Update pylint config - [`7a976de`](https://github.com/proxmoxer/proxmoxer/commit/7a976de985fc7b71fdf31d3161f223eeaada38da) Format all code with pre-commit ### 📊 Changes **24 files changed** (+1126 additions, -565 deletions) <details> <summary>View changed files</summary> 📝 `.devcontainer/devcontainer.json` (+1 -3) ➕ `.git-blame-ignore-revs` (+4 -0) ➕ `.pre-commit-config.yaml` (+60 -0) 📝 `.vscode/settings.json` (+18 -1) 📝 `README.rst` (+93 -56) 📝 `dev_requirements.txt` (+1 -0) 📝 `proxmoxer/__init__.py` (+5 -5) 📝 `proxmoxer/backends/__init__.py` (+3 -3) 📝 `proxmoxer/backends/base_ssh.py` (+27 -24) 📝 `proxmoxer/backends/https.py` (+143 -74) 📝 `proxmoxer/backends/openssh.py` (+47 -27) 📝 `proxmoxer/backends/ssh_paramiko.py` (+52 -31) 📝 `proxmoxer/core.py` (+51 -29) ➕ `pyproject.toml` (+3 -0) ➕ `setup.cfg` (+17 -0) 📝 `setup.py` (+25 -24) 📝 `tests/__init__.py` (+3 -4) 📝 `tests/base/__init__.py` (+3 -4) 📝 `tests/base/base_ssh_suite.py` (+85 -59) 📝 `tests/https_helpers_tests.py` (+47 -34) _...and 4 more files_ </details> ### 📄 Description * Added configuration for formatting/linting * Added pre-commit tool and configured to run desired formatters/linters * Applied formatting/linting to all files * Created file to use with `blame.ignorerevsfile` git config to ignore the bulk-formatting commit from blame * Configured development environment to use formatting tooling --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 15:46:45 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/proxmoxer#166

No description provided.

Rows
Columns